Bug#853322: atanks: ftbfs with GCC-7

[Matthias Klose]

Package: src:atanks
Version: 6.5~dfsg-2
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-7

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/atanks_6.5~dfsg-2_unstable_gcc7.log
The last lines of the build log are at the end of this report.

To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html

[...]
Makefile:284: recipe for target 'obj/atanks.o' failed
make[1]: *** [obj/atanks.o] Error 1
In file included from src/menu.h:24:0,
                 from src/optionitemmenu.cpp:2:
src/optionitem.h: In constructor 'OptionItem<tgt_T, opt_T>::OptionItem(int32_t, tgt_T*, int32_t (*)(tgt_T*, int32_t), const char*, int32_t, BUTTON*, int32_t, int32_t, int32_t, int32_t, int32_t)':
src/optionitem.h:304:16: error: invalid use of incomplete type 'class BUTTON'
    this->button->getLocation(this->left, this->top, this->width, this->height);
                ^~
In file included from src/optionitemmenu.h:24:0,
                 from src/optionitemmenu.cpp:1:
src/optionitembase.h:40:7: note: forward declaration of 'class BUTTON'
 class BUTTON;
       ^~~~~~
In file included from src/menu.h:24:0,
                 from src/player.cpp:25:
src/optionitem.h: In constructor 'OptionItem<tgt_T, opt_T>::OptionItem(int32_t, tgt_T*, int32_t (*)(tgt_T*, int32_t), const char*, int32_t, BUTTON*, int32_t, int32_t, int32_t, int32_t, int32_t)':
src/optionitem.h:304:16: error: invalid use of incomplete type 'class BUTTON'
    this->button->getLocation(this->left, this->top, this->width, this->height);
                ^~
In file included from src/optionitem.h:24:0,
                 from src/menu.h:24,
                 from src/player.cpp:25:
src/optionitembase.h:40:7: note: forward declaration of 'class BUTTON'
 class BUTTON;
       ^~~~~~
Makefile:284: recipe for target 'obj/optionitemmenu.o' failed
make[1]: *** [obj/optionitemmenu.o] Error 1
src/gameloop.cpp: In function 'void draw_eor_scoreboard()':
src/gameloop.cpp:1789:20: warning: '%6d' directive output may be truncated writing between 6 and 11 bytes into a region of size 7 [-Wformat-truncation=]
 static inline void draw_eor_scoreboard()
                    ^~~~~~~~~~~~~~~~~~~
src/gameloop.cpp:1789:20: note: using the range [1, -2147483648] for directive argument
src/gameloop.cpp:1829:12: note: format output between 29 and 49 bytes into a destination of size 29
    snprintf(scoTxt, 29, " %6d %6d %6d %6d",
    ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       env.players[z]->kills,
       ~~~~~~~~~~~~~~~~~~~~~~
       env.players[z]->killed,
       ~~~~~~~~~~~~~~~~~~~~~~~
       env.players[z]->killed - env.players[z]->kills,
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       env.players[z]->score);
       ~~~~~~~~~~~~~~~~~~~~~~
Makefile:284: recipe for target 'obj/player.o' failed
make[1]: *** [obj/player.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j64 returned exit code 2
debian/rules:13: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2