Bug#869630: game-data-packager: Please add support for Heroes of Might and Magic III

[Alexandre Detiste]

2017-07-25 20:41 GMT+02:00 Johannes Schauer <josch at debian.org>:
> Hi Alexandre & Simon,

The core.zip file does bother me.

Does it ever change ? Is it DFSG material ?

If both condition applies; I would prefer to have it packaged as "src:vcmi-data"
and not have GDP break at a random time in the future when the contents
& checksum of this file will get modified. (and vcmi will Depends on vcmi-data)



>> I had at this time filled #783030 (use /usr/share/games/<something> instead
>> of /usr/share/vcmi) but it's just a minor quirk, not the biggest of my
>> concerns.
>
> I pinged upstream about it again. They say they'll fix it ASAP.

That's mostly a distro thing: Fedora enforces the use of /usr/share;
while Mageia enforces /usr/share/games ; Debian mostly uses /usr/share/games,
as this is the traditional thing.

Upstream don't necesserly have to "fix" it if they don't see this a s a bug;
but providing a configure switch or scanning both locations all the time
can make everyone happy without needing patching downstream in distros.



> I attached the output you requested from the latest GOG setup.exe. Specifically
> it's called:
>
> setup_homm_3_complete_4.0_(10665).exe

Thanks



> Then one has to try an end-to-end test when the .yaml file is ok (download
>> via lgogdownloader,cheksumming, extraction with innoextract,
>> repacking,etc...)
>
> I can do more testing if you give me some hints on what to do.

I think I'll just end up buying the GOG version too;

here's the kind of testing I do:
- just plain download from the website with a browser
- packaging from this archive from the local filesystem
- running make-template in "strace" mode to see if there is still much
GOG/windows-only cruft included
  it may real hurt if we wrongfully require some file that is only to
be found in GOG release (or some (un-)official patch)
  that isn't found in other release

- testing again with tools/fake_lgog.py to see if the GOG integration would work
- testing again once with the real lgogdownloader

And then sometimes I also test the fallback mode: GDP should be
able to download & install from GOG.com archives it doesn't even know
about (like a future setup_homm3_complete_4.1... ).

This last step can also be done with fake_lgog.py to avoid downloading
the same files again and again and again.

--

>Ah, I see it already looks in /usr/share/vcmi (which we can work with)
>but Alexandre would prefer /usr/share/games/vcmi. I'm personally less
>convinced by the usefulness of the /usr/share{,/games} split than
>Alexandre is, but I can see the reasoning for wanting to separate it.

It's not that much important.I would had prefered to keep compatibity
between the homm3-data made with the GDP in Stretch
and newer upcoming vcmi and keep it this way.
(but this won't work anyway if the contents of core.zip are dropped
and the music
moved in a separate homm3-music data for example)

Greets,


Alexandre