Bug#853801: qjoypad: segfaults on left click

[Frédéric Brière]

tags 853801 + patch
thanks

On Tue, Jan 31, 2017 at 08:19:18PM -0500, Frédéric Brière wrote:
> Left-clicking on the systray icon (or on the main window with --notray)
> immediately triggers a segfault:
> 
> #1  0x00005616b57ba023 in QString::~QString() (this=0x7ffd91e48d50, __in_chrg=<optimized out>) at /usr/include/qt4/QtCore/qstring.h:880
> #2  0x00005616b57ba023 in LayoutEdit::LayoutEdit(LayoutManager*) (this=0x5616b67266f0, l=<optimized out>) at layout_edit.cpp:50

This is due to fix_ftbfs_clang.patch (#752125), which replaces a proper
array of objects with a malloc'ed blob that is a) never freed, and b)
never initialized.  Therefore, at layout_edit.cpp:50, QString::operator=
gets passed some random garbage as argument, with fairly predictable
results.

Here's a replacement patch that uses std::vector, as suggested by the
Clang documentation.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Properly-fix-752125-closes-853801.patch
Type: text/x-diff
Size: 1997 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20170317/b8dfb9b8/attachment.patch>