Bug#857974: tworld: uninstallable after binNMU

[James Cowgill]

Hi,

On 19/03/17 20:32, Marcio de Souza Oliveira wrote:
> Em 19-03-2017 16:21, James Cowgill escreveu:
>> Control: tags -1 - pending
>>
>> Hi,
> Hi,
>> I've canceled this NMU because it is incorrect and does not fix the bug
>> here.
>>
>> Your change has no effect on the binNMUability of tworld. The problem
>> here is that --link-doc inserts a tworld-data (= ${binary:Version}) into
>> misc:Depends which can never be satisfied if the package is binNMUed.
> 
> James the alteration in Debdiff really not resolve the problem that
> --link-doc.
> But bypass problem, because in hourly that comparation the version,
> the package tworld accepts depends version bigger or equal, and installs
> correctly.
> 
> -Depends: ${shlibs:Depends}, ${misc:Depends}, tworld-data (=
> ${source:Version})
> *+Depends: ${shlibs:Depends}, ${misc:Depends}, tworld-data (>=
> ${source:Version})*

dh_installdocs --link-doc currently works by adding a "tworld-data
(=${binary:Version})" dependency which is wrong for an arch:any ->
arch:all relationship. There is nothing you can change in debian/control
which will make tworld installable after this is added.

>> Example binNMU with your patch:
>>> tworld_1.3.2-2.1+b1_amd64.deb
>>> -----------------------------
>>>  new debian package, version 2.0.
>>>  size 98444 bytes: control archive=1239 bytes.
>>>     1415 bytes,    26 lines      control              
>>>      307 bytes,     5 lines      md5sums              
>>>      185 bytes,     7 lines   *  postinst             #!/bin/sh
>>>      160 bytes,     5 lines   *  postrm               #!/bin/sh
>>>  Package: tworld
>>>  Source: tworld (1.3.2-2.1)
>>>  Version: 1.3.2-2.1+b1
>>>  Architecture: amd64
>>>  Maintainer: Debian Games Team <pkg-games-devel at lists.alioth.debian.org>
>>>  Installed-Size: 226
>>>  Depends: libc6 (>= 2.14), libsdl1.2debian (>= 1.2.11), tworld-data (= 1.3.2-2.1+b1)
> Why not remove *(>= ${source:Version})* the control? Is it really
> necessary?

Possibly not, but using this dependency is the easiest way to ensure
tworld works. If you remove it, you have to check that tworld works with
all versions of tworld-data (past and future) which is difficult to get
right.

> If removes the *(>= ${source:Version}), *would not the latest version of
> tworld-data be installed?

The issue is not tworld-data, but tworld. And no it still won't work if
it's binNMUed for the same reason as above.

I think that with the current debhelper situation, the only nice
solution is to remove --link-doc from tworld.

James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20170319/e3ccb499/attachment.sig>