Bug#906746: freeorion FTBFS on armel/armhf: virtual memory exhausted: Cannot allocate memory

[Adrian Bunk]

Source: freeorion
Version: 0.4.8~RC2-1
Severity: serious
Tags: ftbfs patch

https://buildd.debian.org/status/package.php?p=freeorion

...
[ 18%] Building CXX object CMakeFiles/freeorionparseobj.dir/parse/ValueRefParser.cpp.o
/usr/bin/c++  -DBINPATH=\"/usr/bin\" -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LINK -DBOOST_OPTIONAL_CONFIG_USE_OLD_IMPLEMENTATION_OF_OPTIONAL -DENABLE_BINRELOC -DFREEORION_BUILD_PARSE -DFREEORION_LINUX -DNDEBUG -DSHAREPATH=\"/usr/share\" -isystem "/<<PKGBUILDDIR>>/GG"  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Os -DNDEBUG -fPIC   -Wall -fvisibility=hidden -O3 -std=c++11 -o CMakeFiles/freeorionparseobj.dir/parse/ValueRefParser.cpp.o -c "/<<PKGBUILDDIR>>/parse/ValueRefParser.cpp"
virtual memory exhausted: Cannot allocate memory


Changes in the patch below:
- less debug info (-g1) on all 32bit architectures except i386
- optimizing for size instead of speed with -Os (MinSizeRel)
  does not help with this kind of problems, "Release" is
  appropriate to make cmake not overwrite the added -gq
- build on linux-any

With these changes the build succeeded on armel and mips,
which should cover this kind of problems for all
release architectures.

--- debian/control.old	2018-08-19 19:31:03.498132567 +0000
+++ debian/control	2018-08-19 20:09:50.782947393 +0000
@@ -30,7 +30,7 @@
 Vcs-Browser: https://anonscm.debian.org/cgit/pkg-games/freeorion.git
 
 Package: freeorion
-Architecture: alpha amd64 arm64 armel armhf hppa i386 mips64el powerpc ppc64 ppc64el s390x sparc64 x32
+Architecture: linux-any
 Depends:
  freeorion-data (= ${source:Version}),
  ${misc:Depends},
--- debian/rules.old	2018-08-19 19:21:28.459317241 +0000
+++ debian/rules	2018-08-19 19:50:26.455475862 +0000
@@ -4,14 +4,17 @@
 export CCACHE_DIR=$(CURDIR)/ccache
 DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
 DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
-WEAK_HOSTS := armel armhf
 
-ifneq (,$(findstring $(DEB_HOST_ARCH),$(WEAK_HOSTS)))
+MAX  := 2
+TYPE := RelWithDebInfo
+
+ifeq (32,$(DEB_HOST_ARCH_BITS))
+ifeq (,$(filter $(DEB_HOST_ARCH), i386))
 	MAX  := 1
-	TYPE := MinSizeRel
-else
-	MAX  := 2
-	TYPE := RelWithDebInfo
+	TYPE := Release
+	export DEB_CFLAGS_MAINT_APPEND = -g1
+	export DEB_CXXFLAGS_MAINT_APPEND = -g1
+endif
 endif
 
 %: