Bug#916496: xcom-ufo: cannot build package from GOG 2.0.0.4 installer

[Timothy Allen]

Package: game-data-packager
Version: 61
Severity: normal

Dear Maintainer,

I bought X-Com: UFO Defense from GOG.com, and downloaded it with
"lgogdownloader" (packaged by Debian), producing a file named
setup_xcom_ufo_defense_2.0.0.4.exe, with MD5sum
2bf8035e375a2510807dcc27499d5f99.

I ran "game-data-packager xcom-ufo
/path/to/setup_xcom_ufo_defense_2.0.0.4.exe", the installer files were
extracted, and it printed a whole lot of "identifying..." lines, then spat out
some errors:

[...]
identifying
/tmp/gdptmp.c7gazy7p/tmp/setup_xcom_ufo_defense_2.0.0.4.exe.d/app/GEODATA/SMALLSET.DAT
identifying
/tmp/gdptmp.c7gazy7p/tmp/setup_xcom_ufo_defense_2.0.0.4.exe.d/app/GEODATA/BIGLETS.DAT
identifying
/tmp/gdptmp.c7gazy7p/tmp/setup_xcom_ufo_defense_2.0.0.4.exe.d/app/GEODATA/GERMAN.DAT
identifying
/tmp/gdptmp.c7gazy7p/tmp/setup_xcom_ufo_defense_2.0.0.4.exe.d/app/GEODATA/ENGLISH.DAT
identifying
/tmp/gdptmp.c7gazy7p/tmp/setup_xcom_ufo_defense_2.0.0.4.exe.d/app/GEODATA/FRENCH.DAT
[...]
WARNING:game_data_packager.build:found possible "sound/roland.cat" but it is
not one of the expected versions:
    file:
/tmp/gdptmp.c7gazy7p/tmp/setup_xcom_ufo_defense_2.0.0.4.exe.d/app/SOUND/ROLAND.CAT
    size:   143866 bytes
    md5:    8421cdcbe91b1b3e4818d470f32ca859
    sha1:   14a236be4e16b7040367dea87e25549d6ff290ba
    sha256: 6d98825b620eedb563f664161f86a391d60a0102c811400382ff1d9685913836
expected:
  SOUND/ROLAND.CAT:
    size:   93853 bytes
    md5:    7194c1480e6ce2d3e188133ece4fdefb
    sha1:   None
    sha256: None

ERROR:game_data_packager.build:/home/st/Archives/Game Data/Windows
Games/xcom_ufo_defense/setup_xcom_ufo_defense_2.0.0.4.exe should have provided
GEODATA/BIGLETS.DAT but did not
ERROR:game_data_packager.build:/home/st/Archives/Game Data/Windows
Games/xcom_ufo_defense/setup_xcom_ufo_defense_2.0.0.4.exe should have provided
GEODATA/ENGLISH.DAT but did not
ERROR:game_data_packager.build:/home/st/Archives/Game Data/Windows
Games/xcom_ufo_defense/setup_xcom_ufo_defense_2.0.0.4.exe should have provided
GEODATA/FRENCH.DAT but did not
ERROR:game_data_packager.build:/home/st/Archives/Game Data/Windows
Games/xcom_ufo_defense/setup_xcom_ufo_defense_2.0.0.4.exe should have provided
GEODATA/GERMAN.DAT but did not
ERROR:game_data_packager.build:/home/st/Archives/Game Data/Windows
Games/xcom_ufo_defense/setup_xcom_ufo_defense_2.0.0.4.exe should have provided
GEODATA/SMALLSET.DAT but did not
ERROR:game_data_packager.build:/home/st/Archives/Game Data/Windows
Games/xcom_ufo_defense/setup_xcom_ufo_defense_2.0.0.4.exe should have provided
SOUND/ROLAND.CAT but did not
ERROR:game_data_packager.build:Unable to complete any packages.

I suspect that the GOG installer might already have the OpenXCOM data patch[1]
installed, although I can't find any specific statements for or against it.

[1]: https://openxcom.org/downloads-extras/



-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages game-data-packager depends on:
ii  dpkg            1.19.2
ii  fakeroot        1.23-1
ii  python3         3.6.7-1
ii  python3-debian  0.1.33
ii  python3-yaml    3.13-1

Versions of packages game-data-packager recommends:
ii  game-data-packager-runtime  61

Versions of packages game-data-packager suggests:
pn  arj                                <none>
ii  binutils                           2.31.1-10
ii  cabextract                         1.9-1
pn  cdparanoia                         <none>
pn  dynamite                           <none>
ii  gcc                                4:8.2.0-2
ii  gdebi                              0.9.5.7+nmu2
ii  gir1.2-gdkpixbuf-2.0               2.38.0+dfsg-6
ii  innoextract                        1.7-2+b1
pn  lgc-pg                             <none>
ii  lgogdownloader                     3.4-1+b1
pn  lhasa | jlha-utils | lzh-archiver  <none>
ii  make                               4.2.1-1.2
ii  p7zip-full                         16.02+dfsg-6
ii  python3-gi                         3.30.2-1
ii  steam                              1.0.0.56-1
pn  steamcmd                           <none>
pn  unace-nonfree                      <none>
ii  unar                               1.10.1-2+b3
pn  unrar                              <none>
pn  unshield                           <none>
ii  unzip                              6.0-21
ii  vorbis-tools                       1.4.0-10.1
pn  xdelta                             <none>
ii  xdelta3                            3.0.11-dfsg-1+b1

-- no debconf information