Bug#887664: [debhelper-devel] Bug#887688: debhelper: empty build of src:ck

[Niels Thykier]

Sven Joachim:
> On 2018-01-21 23:24 +0200, Adrian Bunk wrote:
> 
>> On Fri, Jan 19, 2018 at 07:51:00PM +0000, Niels Thykier wrote:
>>> ...
>>>   The question now is: How many packages are affected by it?  If it is
>>> sufficiently low, it might be worth doing the clean up now to simplify
>>> packaging in general.  But in worst case, we will have to revert for now
>>> and reintroduce this to compat 12.
>>
>> My current list for "builds with 11 and FTBFS with 11.1.3" is:
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/apr.html
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ck.html
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/cpputest.html
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/debian-handbook.html
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/iaxmodem.html
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/moarvm.html
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/openal-soft.html
[...]
>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/jscommunicator.html
[...]

Indeed; all of these just have a .PHONY build target and nothing else
(i.e. they won't also hit #887482 AFAICT).  They all basically just want
debhelper to ignore the explicit target and inline the sequence.

I will dig a bit in the code

>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/biojava-live.html
> 
> This ends in
> 
> ,----
> | dh_installdocs
> | make[1]: Leaving directory '/build/1st/biojava-live-1.7.1'
> |  dpkg-genbuildinfo --build=binary
> | dpkg-genbuildinfo: error: binary build with no binary artifacts found; .buildinfo is meaningless
> | dpkg-buildpackage: error: dpkg-genbuildinfo --build=binary subprocess returned exit status 25
> `----
> 
> In other words, dh_installdeb was not run, apparently because there is a broken
> explicit rule for the binary-indep target.
> 

The rule being:

"""
> binary-indep: build install
> 	dh_testdir
> 	dh_testroot
> 	dh_installchangelogs 
> 	dh_installdocs
"""

So yes,  that is rather incomplete.  It was probably saved by #880840
previously.

>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/jansson.html
> 
> [...]
> which seems to have a similar cause as #887482.
> 

Indeed.  The package uses a work around for #836699 that now triggers
this issue.  Let's keep the discussion for these problems in #887482.

>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/scidavis.html
> 
> Failed because 'dh_makeshlibs --no-act' returned an error.  Niels might
> know why this is now the case and used to be different.
> 
> Cheers,
>        Sven
> 
> [...]

Bug in --no-act code; fixed in master now - thanks for spotting it. :)

Thanks,
~Niels