Bug#892917: love: use BD on lua OR luajit

[James Cowgill]

Hi,

On 14/03/18 13:37, Frédéric Bonnard wrote:
> Package: src:love
> Version: 0.9.1-4
> 
> --
> 
> Dear maintainer,
> 
> at the moment both liblua5.1-0-dev and libluajit-5.1-dev are required to
> build. I think one or the other exclusively should be enough, and your
> d/rules specifies one or the other already.
> The best being to require first libluajit-5.1-dev if available and
> fallback on liblua5.1-0-dev.
> This way, love will benefit from luajit's speed if possible but will
> build on more architectures as well thanks to lua's portability (that
> should fix the BD-Uninstallable status on some architectures)
> Here is a patch for this.
> Also, ppc64el's support in luajit is unsure in the long term, so with
> the patch, we ensure to be able to still have love on this architecture
> even if luajit drops ppc64el support (and thus fix the current FTBFS :
> https://buildd.debian.org/status/fetch.php?pkg=love&arch=ppc64el&ver=0.9.1-4&stamp=1503721727&raw=0

Bear in mind the buildds ignore alternatives in build-dependencies, so
from their perspective, your patch is equivalent to dropping the non-jit
dependency and won't fix any of the BD-Uninstallable architectures.

I think keeping the current build-dependency on liblua5.1-0-dev but
restricting it to the architectures where luajit is not used should do
what you want.

James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-games-devel/attachments/20180314/4223d24e/attachment.sig>