Bug#897486: pcsxr: FTBFS: ../libpcsxcore/cdriso.c:1222:12: error: conflicting types for 'uncompress2'

[Lucas Nussbaum]

Source: pcsxr
Version: 1.9.94-2
Severity: serious
Tags: buster sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20180502 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I../include  -DLOCALE_DIR=\"/usr/share/locale/\" -I../include -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -c -o cdriso.o `test -f '../libpcsxcore/cdriso.c' || echo './'`../libpcsxcore/cdriso.c
> ../libpcsxcore/cdriso.c:1222:12: error: conflicting types for 'uncompress2'
>  static int uncompress2(void *out, unsigned long *out_size, void *in, unsigned long in_size)
>             ^~~~~~~~~~~
> In file included from ../libpcsxcore/psxcommon.h:45:0,
>                  from ../libpcsxcore/cdriso.c:22:
> /usr/include/zlib.h:1283:21: note: previous declaration of 'uncompress2' was here
>  ZEXTERN int ZEXPORT uncompress2 OF((Bytef *dest,   uLongf *destLen,
>                      ^~~~~~~~~~~
> ../libpcsxcore/cdriso.c: In function 'ISOreadTrack':
> ../libpcsxcore/cdriso.c:1824:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(subbuffer, 1, SUB_FRAMESIZE, subHandle);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c: In function 'ISOopen':
> ../libpcsxcore/cdriso.c:1646:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(&modeTest, 4, 1, cdHandle);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c: In function 'cdread_sub_mixed':
> ../libpcsxcore/cdriso.c:1215:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(subbuffer, 1, SUB_FRAMESIZE, f);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c: In function 'parsemds':
> ../libpcsxcore/cdriso.c:836:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(&i, 1, sizeof(unsigned int), fi);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:846:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(&offset, 1, sizeof(unsigned int), fi);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:852:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(&s, 1, sizeof(unsigned short), fi);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:858:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(&offset, 1, sizeof(unsigned int), fi);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:887:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(&extra_offset, 1, sizeof(unsigned int), fi);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:892:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(&l, 1, sizeof(unsigned int), fi);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:898:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(&l, 1, sizeof(unsigned int), fi);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:904:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(&l, 1, sizeof(unsigned int), fi);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c: In function 'handlepbp':
> ../libpcsxcore/cdriso.c:960:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(psar_sig, 1, sizeof(psar_sig), cdHandle);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:996:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(psar_sig, 1, sizeof(psar_sig), cdHandle);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:1014:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(&toc_entry, 1, sizeof(toc_entry), cdHandle);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:1017:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>   fread(&toc_entry, 1, sizeof(toc_entry), cdHandle);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../libpcsxcore/cdriso.c:1022:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
>    fread(&toc_entry, 1, sizeof(toc_entry), cdHandle);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> make[2]: *** [Makefile:913: cdriso.o] Error 1

The full build log is available from:
   http://aws-logs.debian.net/2018/05/02/pcsxr_1.9.94-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.