Bug#897861: simutrans: ftbfs with GCC-8

[Matthias Klose]

Package: src:simutrans
Version: 120.2.2-3
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-8

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
severity of this report will be raised before the buster release.

The full build log can be found at:
http://aws-logs.debian.net/2018/05/01/gcc8/simutrans_120.2.2-3_unstable_gcc8.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 8, either set CC=gcc-8 CXX=g++-8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-8/porting_to.html

[...]
                  ^
bauer/../utils/../simtypes.h:40:18: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
bauer/../utils/../simtypes.h:40:18: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
bauer/../utils/../simtypes.h:46:21: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
 #if CXX11(4, 7, 1400)
                     ^
bauer/../utils/../simtypes.h:46:21: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
bauer/../utils/../simtypes.h:46:21: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
In file included from bauer/../tpl/weighted_vector_tpl.h:7,
                 from bauer/../simworld.h:23,
                 from bauer/../simtool.h:11,
                 from bauer/brueckenbauer.cc:11:
bauer/../tpl/../macros.h:7:42: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
 #if !defined __GNUC__ || GCC_ATLEAST(3, 0)
                                          ^
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
g++ -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -std=gnu++11 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -O3 -DNDEBUG -Wall -W -Wcast-qual -Wpointer-arith -Wcast-align -DUSE_C -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DCOLOUR_DEPTH=16 -c -MMD -o /<<PKGBUILDDIR>>/bauer/wegbauer.o bauer/wegbauer.cc
In file included from bauer/../utils/log.h:13,
                 from bauer/../simdebug.h:23,
                 from bauer/wegbauer.cc:14:
bauer/../utils/../simtypes.h:40:18: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
 #if CXX11(4, 4, 0)
                  ^
bauer/../utils/../simtypes.h:40:18: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
bauer/../utils/../simtypes.h:40:18: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
bauer/../utils/../simtypes.h:46:21: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
 #if CXX11(4, 7, 1400)
                     ^
bauer/../utils/../simtypes.h:46:21: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
bauer/../utils/../simtypes.h:46:21: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
In file included from bauer/../tpl/weighted_vector_tpl.h:7,
                 from bauer/../simworld.h:23,
                 from bauer/wegbauer.cc:15:
bauer/../tpl/../macros.h:7:42: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
 #if !defined __GNUC__ || GCC_ATLEAST(3, 0)
                                          ^
bauer/wegbauer.cc: In member function 'void way_builder_t::check_for_bridge(const grund_t*, const grund_t*, const vector_tpl<koord3d>&)':
bauer/wegbauer.cc:1096:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
     }
     ^
bauer/wegbauer.cc:1099:4: note: here
    default:
    ^~~~~~~
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j8 -Oline "INSTALL=install --strip-program=true" returned exit code 2
make[1]: *** [debian/rules:22: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:19: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2