Bug#912171: pcsxr: Cannot configure/use 2nd joypad

[Alessandro Grassi]

Package: pcsxr
Version: 1.9.94-4
Severity: normal
Tags: patch

Dear Maintainer,

when pcsxr is started with two USB joypads connected, it is not possible to configure
them (the configuration window does not open). With only one joypad,
everything works fine.
I tracked the cause to the /pcsxr/plugins/dfinput/cfg-gtk.c file at line 610:

sprintf(buf, "%d: %s", j + 1, SDL_JoystickName(j));

The call to SDL_JoystickName() was correct with SDL 1.2, but it is not anymore
with SDL 2. In fact, in the upstream code I find this code instead of that single line:

#if SDL_VERSION_ATLEAST(2, 0, 0)
    SDL_Joystick *joystick = SDL_JoystickOpen(j);
    sprintf(buf, "%d: %s", j + 1, SDL_JoystickName(joystick));
#else
    sprintf(buf, "%d: %s", j + 1, SDL_JoystickName(j));
#endif

By replacing with this code and recompiling the package, the problem is solved.


-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8), LANGUAGE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages pcsxr depends on:
ii  libc6               2.27-5
ii  libgdk-pixbuf2.0-0  2.36.12-1
ii  libgl1              1.0.0+git20180308-3
ii  libglib2.0-0        2.58.1-2
ii  libgtk-3-0          3.24.0-3
ii  libpango-1.0-0      1.42.4-3
ii  libsdl2-2.0-0       2.0.8+dfsg1-1+b1
ii  libx11-6            2:1.6.5-1
ii  libxext6            2:1.3.3-1+b2
ii  libxtst6            2:1.2.3-1
ii  libxv1              2:1.0.11-1
ii  libxxf86vm1         1:1.1.4-1+b2
ii  zlib1g              1:1.2.11.dfsg-1

pcsxr recommends no packages.

pcsxr suggests no packages.

-- no debconf information