Bug#927456: irrlicht makefile does not honor CFLAGS (was: irrlicht makefiles does not honors CFLAGS and CXXFLAGS, so neither hardening)

[Juhani Numminen]

Control: retitle -1 irrlicht makefile does not honor CFLAGS
Control: severity -1 minor

On Fri, 19 Apr 2019 23:33:53 -0400 PICCORO McKAY Lenz <mckaygerhard at gmail.com> wrote:

> in Makefile line 84 we have a non override CFLAG set  as:
> 
> irrlicht-1.8.4.0/source/Irrlicht/Makefile
> 
> CFLAGS := -O3 -fexpensive-optimizations -DPNG_THREAD_UNSAFE_OK
> -DPNG_NO_MMX_CODE -DPNG_NO_MNG_FEATUR
> ES
>
> so i set to serious due irrlicht on Debian uses system PNG and JPEG
> libraries.. so here we can see more that just only not honor the CFLAGS..
> take a shot to the "NO_MMX_CODE"

After looking at the build logs[1], I think this is not as serious as it
first seems. You are correct that CFLAGS is overridden, but I can't see
any C code being compiled. The Makefile honors the CXXFLAGS, CPPFLAGS and
LDFLAGS and so the compiled library is indeed hardened.

[1] https://buildd.debian.org/status/package.php?p=irrlicht

Regards,
Juhani