Bug#916496: xcom-ufo: cannot build package from GOG 2.0.0.4 installer

[Simon McVittie]

On Sat, 02 Feb 2019 at 20:17:38 +1100, Tim Allen wrote:
> I found a site[1] claiming to host the official 1.1, 1.2, 1.3 and 1.4
> patches, alongside a bunch of other unofficial patches. It turns out
> that the ROLAND.CAT that game-data-packager was looking for (MD5:
> 7194c14...) is part of the UFO 1.4 update. The site says[2]:
> 
> # This patch fixes many stability issues, some game stopping research
> # bugs And removed the startup copy protection. However it also replaces
> # the sounds with ones that are not as good as the originals.

Should we be preferring to package the unpatched ROLAND.CAT (143866 bytes, as
shipped by GOG) rather than the v1.4 ROLAND.CAT (93853 bytes, as shipped by
Steam) if we can see both, then? The YAML syntax lets us prefer one version
over others.

In the absence of other considerations, we generally prefer the latest official
patch, or the latest unofficial patch if it has important fixes and good
compatibility.

I don't own any version of this game (that I know of - Humble Bundle being what
it is, I might have a Steam copy that I don't know about!) so I'm relying on
people who do, like you and Alexandre.

> The BIGLETS.DAT and SMALLSET.DAT files don't appear in any
> patch, official or unofficial, expected hash or otherwise, so I have no
> idea where they came from, or why the Steam and GOG releases differ.

*shrug* if they work, they're probably good enough...

> The "obsolete" ENGLISH.DAT, FRENCH.DAT and GERMAN.DAT that the GOG
> release includes come from the 1.2 and 1.3 official patches. The
> versions that game-data-packager expected aren't present.

The addition of xcom-ufo.yaml in commit a5fd5cb5 had details of the Steam
release (Steam app ID 7760), so I assume the versions now tagged as "updated"
are from Steam. (Alexandre, can you confirm this?) It isn't unheard of for a
Steam rerelease to have new changes that weren't in any previous official
patches.

    smcv