Bug#924291: closed by Markus Koschany <apo at debian.org> (Bug#924291: fixed in netrek-client-cow 3.3.1-2)

[Markus Koschany]

Am 24.03.19 um 07:33 schrieb Helmut Grohne:
> Control: reopen -1
> 
> On Thu, Mar 21, 2019 at 12:54:04AM +0000, Debian Bug Tracking System wrote:
>>    * Fix possible infinite loop. (Closes: #924291)
> 
> Thank you for the timely fix. Unfortunately, it doesn't work as the
> variables are improperly escaped. The build continues to loop.
> 
> The patch has:
> 
> +	attempts=32; until ./mkkey $(KEYFILE) "Client Of Win" $(DESC) $(MAKER) $(COMMENT) "inl,standard2"; do attempts=$(attempts - 1); test $(attempts) -le 0 && exit 1; sleep 1; done
> 
> It tries to interpolate make variables named "attempts - 1" and
> "attempts". Those are empty so the test expression always fails. With
> proper escaping it looks like this:
> 
> +	attempts=32; until ./mkkey $(KEYFILE) "Client Of Win" $(DESC) $(MAKER) $(COMMENT) "inl,standard2"; do attempts=$$((attempts - 1)); test $$(attempts) -le 0 && exit 1; sleep 1; done
> 
> The double $ is unescaped by make to a single $ and the double braces
> are required to perform arithmetic in shell.

I have just uploaded a corrected version. Please provide a patch next
time that can be applied right away. Your original proposed solution
didn't work either and even caused a FTBFS:


attempts=32; until ./mkkey ...; do attempts=$((attempts - 1)); test
$attempts -le 0 && exit 1; sleep 1; done

Unfortunately I didn't remember the double dollar sign in makefiles too.

Regards,

Markus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-games-devel/attachments/20190324/b4bc90c6/attachment.sig>