Bug#956080: gamazons FTCBFS: multiple reasons

[Helmut Grohne]

Source: gamazons
Version: 0.83-9
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

gamazons fails to cross build from source. The immediate failure happens
during dh_auto_clean. It invokes make distclean. The makefile figures
that its config.status is outdated and that it needs to configure again.
It does so for the build architecture, misses dependencies (which are
only requested for the host architecture) and fails. A simple way around
this is touching config.status before invoking make distclean. The
attached patch implements that.

Then, ./configure uses the build architecture pkg-config. This is a bug
in the PKG_CHECK_MODULES macro. The file aclocal.m4 ships a broken,
outdated, embedded copy this macro. The upstream macro as shipped by
pkg-config is fixed. Please remove this copy to use the fixed upstream
version. Failing that, please update your embedded copy and register it
with the security tracker. Please refer to
https://wiki.debian.org/EmbeddedCodeCopies for details on the process.
Please remember that since ./configure is not regenerated during a
package build, you must do so manually before your upload in both cases.
I'm not including a patch for this second issue, because it is already
fixed in pkg-config itself.

Helmut
-------------- next part --------------
diff --minimal -Nru gamazons-0.83/debian/changelog gamazons-0.83/debian/changelog
--- gamazons-0.83/debian/changelog	2018-08-18 14:08:29.000000000 +0200
+++ gamazons-0.83/debian/changelog	2020-04-06 18:50:24.000000000 +0200
@@ -1,3 +1,11 @@
+gamazons (0.83-9.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Improve cross building: Don't configure during make distclean.
+    (Close: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Mon, 06 Apr 2020 18:50:24 +0200
+
 gamazons (0.83-9) unstable; urgency=medium
 
   * Replace libgnomeui-dev with libgoocanvas-2.0-dev.
diff --minimal -Nru gamazons-0.83/debian/rules gamazons-0.83/debian/rules
--- gamazons-0.83/debian/rules	2018-08-18 14:08:29.000000000 +0200
+++ gamazons-0.83/debian/rules	2020-04-06 18:50:15.000000000 +0200
@@ -4,6 +4,11 @@
 %:
 	dh $@ --without autoreconf --with autotools_dev
 
+override_dh_auto_clean:
+	touch config.status
+	dh_auto_clean
+	rm -f config.status
+
 override_dh_auto_configure:
 	dh_auto_configure -- \
 		--prefix=/usr \