Bug#957040: biniax2: ftbfs with GCC-10

[Matthias Klose]

Package: src:biniax2
Version: 1.30-4
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/biniax2_1.30-4_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
SCHROOT_UID=1001
SCHROOT_USER=user42
SHELL=/bin/sh
USER=user42

dpkg-buildpackage
-----------------

Command: dpkg-buildpackage -us -uc -b -rfakeroot
dpkg-buildpackage: info: source package biniax2
dpkg-buildpackage: info: source version 1.30-4
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean
   dh_auto_clean
   dh_clean
 debian/rules build
dh build
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure
   dh_auto_build
	make -j4
make[1]: Entering directory '/<<PKGBUILDDIR>>'
gcc `dpkg-buildflags --get CFLAGS` `dpkg-buildflags --get CPPFLAGS` `sdl-config --libs --cflags` -DDATADIR=\"/usr/share/games/biniax2\" biniax.c hof.c desktop/cfg.c desktop/gfx.c desktop/snd.c desktop/inp.c desktop/sys.c -I . -I desktop -o biniax2 -lSDL -lSDL_mixer -lSDL_image `dpkg-buildflags --get LDFLAGS`
biniax.c: In function ‘saveFileName’:
cc1: warning: function may return address of local variable [-Wreturn-local-addr]
biniax.c:1220:7: note: declared here
 1220 |  char filename[1024];
      |       ^~~~~~~~
hof.c: In function ‘hofOldDebianInit’:
hof.c:420:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  420 |   fread( Hof.arcade[i].name, 1, cHofNameLen, file );
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c:426:3: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  426 |   fread( Hof.tactic[i].name, 1, cHofNameLen, file );
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hof.c: In function ‘hofFileName’:
cc1: warning: function may return address of local variable [-Wreturn-local-addr]
hof.c:108:7: note: declared here
  108 |  char filename[1024];
      |       ^~~~~~~~
desktop/cfg.c: In function ‘cfgInit’:
desktop/cfg.c:130:4: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  130 |    fgets( buffer, _Cfg_Buffer, f );
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
desktop/cfg.c:134:4: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  134 |    fgets( buffer, _Cfg_Buffer, f );
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
desktop/cfg.c:138:4: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  138 |    fgets( buffer, _Cfg_Buffer, f );
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
desktop/cfg.c:142:4: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  142 |    fgets( buffer, _Cfg_Buffer, f );
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/ld: /tmp/ccOAdsp9.o:./desktop/inp.h:72: multiple definition of `_Inp'; /tmp/cc9ef978.o:./desktop/inp.h:72: first defined here
/usr/bin/ld: /tmp/ccHKrET9.o:./desktop/inp.h:72: multiple definition of `_Inp'; /tmp/cc9ef978.o:./desktop/inp.h:72: first defined here
/usr/bin/ld: /tmp/ccCYHmab.o:./desktop/inp.h:72: multiple definition of `_Inp'; /tmp/cc9ef978.o:./desktop/inp.h:72: first defined here
/usr/bin/ld: /tmp/ccTHmxDc.o:./desktop/inp.h:72: multiple definition of `_Inp'; /tmp/cc9ef978.o:./desktop/inp.h:72: first defined here
/usr/bin/ld: /tmp/ccINupje.o:./desktop/inp.h:72: multiple definition of `_Inp'; /tmp/cc9ef978.o:./desktop/inp.h:72: first defined here
/usr/bin/ld: /tmp/ccl2rp9f.o:./desktop/inp.h:72: multiple definition of `_Inp'; /tmp/cc9ef978.o:./desktop/inp.h:72: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [makefile:18: biniax] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:6: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2