Bug#957232: freesweep: ftbfs with GCC-10

[Matthias Klose]

Package: src:freesweep
Version: 1.0.1-1
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/freesweep_1.0.1-1_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
   26 | #define USE_GROUP_BEST_FILE 1
      | 
sl.c: In function ‘LoadGame’:
sl.c:81:2: warning: ignoring return value of ‘fread’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   81 |  fread(Game->Field,
      |  ^~~~~~~~~~~~~~~~~~
   82 |   (Game->Height*((Game->Width % 2 ? (Game->Width) +1 : Game->Width ))/2)
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   83 |   * sizeof(unsigned char), 1, fi);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from stats.c:11:
sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
   66 | #define USE_GROUP_BEST_FILE
      | 
In file included from sweep.h:8,
                 from stats.c:11:
config.h:26: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      | 
gcc -Wall -DVERSION=\"1.0.1\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -c tick.c
gcc -Wall -DVERSION=\"1.0.1\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -c utils.c
gcc -Wall -DVERSION=\"1.0.1\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -c image.c
In file included from tick.c:11:
sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
   66 | #define USE_GROUP_BEST_FILE
      | 
In file included from sweep.h:8,
                 from tick.c:11:
config.h:26: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      | 
In file included from utils.c:11:
sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
   66 | #define USE_GROUP_BEST_FILE
      | 
In file included from sweep.h:8,
                 from utils.c:11:
config.h:26: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      | 
In file included from image.c:11:
sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
   66 | #define USE_GROUP_BEST_FILE
      | 
In file included from sweep.h:8,
                 from image.c:11:
config.h:26: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      | 
gcc -Wall -DVERSION=\"1.0.1\" -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 clear.o drawing.o error.o fgui.o files.o game.o gpl.o main.o pbests.o play.o sl.o stats.o tick.o utils.o image.o -Wl,-z,relro -lm -lncurses  -o freesweep
/usr/bin/ld: drawing.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: error.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: fgui.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: files.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: game.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: gpl.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: main.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: pbests.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: play.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: sl.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: stats.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: tick.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: utils.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
/usr/bin/ld: image.o:./sweep.h:249: multiple definition of `CharSet'; clear.o:./sweep.h:249: first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:46: freesweep] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2