Bug#957316: gtkatlantic: ftbfs with GCC-10

[Matthias Klose]

Package: src:gtkatlantic
Version: 0.6.2-2
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/gtkatlantic_0.6.2-2_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
/usr/bin/ld: client.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: client.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: display.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: display.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: display.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: display.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: display.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: display.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: display.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: eng_frame.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: eng_main.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: game.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: game.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: game.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: game.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: game.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: game.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: game.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: interface.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: interface.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: interface.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: interface.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: interface.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: interface.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: interface.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: load.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: load.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: load.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: load.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: load.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: load.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: load.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: main.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: main.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: main.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: main.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: main.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: main.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: main.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: theme.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: theme.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: theme.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: theme.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: theme.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: theme.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: theme.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: trade.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: trade.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: trade.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: trade.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: trade.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: trade.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: trade.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
/usr/bin/ld: xmlparse.o:./src/global.h:297: multiple definition of `currentgame'; callback.o:./src/global.h:297: first defined here
/usr/bin/ld: xmlparse.o:./src/global.h:546: multiple definition of `global'; callback.o:./src/global.h:546: first defined here
/usr/bin/ld: xmlparse.o:./src/global.h:122: multiple definition of `player_h'; callback.o:./src/global.h:122: first defined here
/usr/bin/ld: xmlparse.o:./src/global.h:478: multiple definition of `data'; callback.o:./src/global.h:478: first defined here
/usr/bin/ld: xmlparse.o:./src/global.h:574: multiple definition of `config'; callback.o:./src/global.h:574: first defined here
/usr/bin/ld: xmlparse.o:./src/global.h:298: multiple definition of `game_h'; callback.o:./src/global.h:298: first defined here
/usr/bin/ld: xmlparse.o:./src/eng_main.h:73: multiple definition of `eng'; callback.o:./src/eng_main.h:73: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:433: gtkatlantic] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:458: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:366: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:6: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2