Bug#957493: liquidwar: ftbfs with GCC-10

[Matthias Klose]

Package: src:liquidwar
Version: 5.6.5-1
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/liquidwar_5.6.5-1_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
Compiling palette.c (cpu=default, debug=no, asm=no)
Compiling parser.c (cpu=default, debug=no, asm=no)
Compiling path.c (cpu=default, debug=no, asm=no)
Compiling ping.c (cpu=default, debug=no, asm=no)
Compiling pion.c (cpu=default, debug=no, asm=no)
Compiling play.c (cpu=default, debug=no, asm=no)
Compiling profile.c (cpu=default, debug=no, asm=no)
Compiling protocol.c (cpu=default, debug=no, asm=no)
protocol.c: In function ‘lw_protocol_ask_who’:
protocol.c:287:32: warning: this statement may fall through [-Wimplicit-fallthrough=]
  287 |                   who->network = 1;
      |                   ~~~~~~~~~~~~~^~~
protocol.c:293:17: note: here
  293 |                 case LW_NETMESS_CODE_LOCAL:
      |                 ^~~~
Compiling random.c (cpu=default, debug=no, asm=no)
Compiling rules.c (cpu=default, debug=no, asm=no)
Compiling score.c (cpu=default, debug=no, asm=no)
Compiling serial.c (cpu=default, debug=no, asm=no)
Compiling sock2cli.c (cpu=default, debug=no, asm=no)
Compiling sockex.c (cpu=default, debug=no, asm=no)
Compiling sockunix.c (cpu=default, debug=no, asm=no)
Compiling sound.c (cpu=default, debug=no, asm=no)
Compiling speeds.c (cpu=default, debug=no, asm=no)
Compiling startinf.c (cpu=default, debug=no, asm=no)
Compiling startup.c (cpu=default, debug=no, asm=no)
Compiling team.c (cpu=default, debug=no, asm=no)
Compiling texture.c (cpu=default, debug=no, asm=no)
Compiling thrdunix.c (cpu=default, debug=no, asm=no)
thrdunix.c: In function ‘lw_thread_start’:
thrdunix.c:84:38: warning: cast between incompatible function types from ‘void (*)(void *)’ to ‘void * (*)(void *)’ [-Wcast-function-type]
   84 |   if (pthread_create (&thread, NULL, (void *(*)(void *)) func, args) == 0)
      |                                      ^
Compiling ticker.c (cpu=default, debug=no, asm=no)
Compiling time.c (cpu=default, debug=no, asm=no)
Compiling viewport.c (cpu=default, debug=no, asm=no)
Compiling volume.c (cpu=default, debug=no, asm=no)
Compiling watchdog.c (cpu=default, debug=no, asm=no)
Compiling wave.c (cpu=default, debug=no, asm=no)
Compiling wwwcli.c (cpu=default, debug=no, asm=no)
Compiling x11icon.c (cpu=default, debug=no, asm=no)
Linking liquidwar (host=default, debug=no, static=no, asm=no)
/usr/bin/ld: fighter.o:./src/fighter.h:62: multiple definition of `FIGHTER_MOVE_X'; autoplay.o:./src/fighter.h:62: first defined here
/usr/bin/ld: fighter.o:./src/fighter.h:63: multiple definition of `FIGHTER_MOVE_Y'; autoplay.o:./src/fighter.h:63: first defined here
/usr/bin/ld: game.o:./src/fighter.h:63: multiple definition of `FIGHTER_MOVE_Y'; autoplay.o:./src/fighter.h:63: first defined here
/usr/bin/ld: game.o:./src/fighter.h:62: multiple definition of `FIGHTER_MOVE_X'; autoplay.o:./src/fighter.h:62: first defined here
/usr/bin/ld: info.o:./src/random.h:70: multiple definition of `LW_RANDOM_ON'; game.o:./src/random.h:70: first defined here
/usr/bin/ld: info.o:./src/random.h:69: multiple definition of `LW_RANDOM_RAW_MAP'; game.o:./src/random.h:69: first defined here
/usr/bin/ld: level.o:./src/random.h:70: multiple definition of `LW_RANDOM_ON'; game.o:./src/random.h:70: first defined here
/usr/bin/ld: level.o:./src/random.h:69: multiple definition of `LW_RANDOM_RAW_MAP'; game.o:./src/random.h:69: first defined here
/usr/bin/ld: map.o:./src/random.h:69: multiple definition of `LW_RANDOM_RAW_MAP'; game.o:./src/random.h:69: first defined here
/usr/bin/ld: map.o:./src/random.h:70: multiple definition of `LW_RANDOM_ON'; game.o:./src/random.h:70: first defined here
/usr/bin/ld: mesh.o:./src/random.h:70: multiple definition of `LW_RANDOM_ON'; game.o:./src/random.h:70: first defined here
/usr/bin/ld: mesh.o:./src/random.h:69: multiple definition of `LW_RANDOM_RAW_MAP'; game.o:./src/random.h:69: first defined here
/usr/bin/ld: netplay.o:./src/random.h:70: multiple definition of `LW_RANDOM_ON'; game.o:./src/random.h:70: first defined here
/usr/bin/ld: netplay.o:./src/random.h:69: multiple definition of `LW_RANDOM_RAW_MAP'; game.o:./src/random.h:69: first defined here
/usr/bin/ld: play.o:./src/random.h:70: multiple definition of `LW_RANDOM_ON'; game.o:./src/random.h:70: first defined here
/usr/bin/ld: play.o:./src/random.h:69: multiple definition of `LW_RANDOM_RAW_MAP'; game.o:./src/random.h:69: first defined here
/usr/bin/ld: random.o:./src/random.h:69: multiple definition of `LW_RANDOM_RAW_MAP'; game.o:./src/random.h:69: first defined here
/usr/bin/ld: random.o:./src/random.h:70: multiple definition of `LW_RANDOM_ON'; game.o:./src/random.h:70: first defined here
/usr/bin/ld: random.o: in function `generate_bitmap':
./src/random.c:129: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:255: liquidwar] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: *** [Makefile:115: build_bin] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2