Bug#957602: nettoe: ftbfs with GCC-10

[Matthias Klose]

Package: src:nettoe
Version: 1.5.1-2
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/nettoe_1.5.1-2_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]

    Build:        x86_64-pc-linux-gnu
    Host:         x86_64-pc-linux-gnu

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_build
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
make  all-recursive
make[2]: Entering directory '/<<PKGBUILDDIR>>'
Making all in src
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
gcc -DNETTOE_PORT=7501 -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -MT ai.o -MD -MP -MF .deps/ai.Tpo -c -o ai.o ai.c
mv -f .deps/ai.Tpo .deps/ai.Po
gcc -DNETTOE_PORT=7501 -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -MT board.o -MD -MP -MF .deps/board.Tpo -c -o board.o board.c
mv -f .deps/board.Tpo .deps/board.Po
gcc -DNETTOE_PORT=7501 -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -MT nettoe.o -MD -MP -MF .deps/nettoe.Tpo -c -o nettoe.o nettoe.c
nettoe.c: In function ‘main’:
nettoe.c:120:3: warning: ignoring return value of ‘setegid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  120 |   setegid(getgid());
      |   ^~~~~~~~~~~~~~~~~
nettoe.c:121:3: warning: ignoring return value of ‘setgid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  121 |   setgid(getgid());
      |   ^~~~~~~~~~~~~~~~
nettoe.c:122:3: warning: ignoring return value of ‘seteuid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  122 |   seteuid(getuid());
      |   ^~~~~~~~~~~~~~~~~
nettoe.c:123:3: warning: ignoring return value of ‘setuid’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  123 |   setuid(getuid());
      |   ^~~~~~~~~~~~~~~~
mv -f .deps/nettoe.Tpo .deps/nettoe.Po
gcc -DNETTOE_PORT=7501 -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -MT matrices.o -MD -MP -MF .deps/matrices.Tpo -c -o matrices.o matrices.c
mv -f .deps/matrices.Tpo .deps/matrices.Po
gcc -DNETTOE_PORT=7501 -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -MT terminal.o -MD -MP -MF .deps/terminal.Tpo -c -o terminal.o terminal.c
terminal.c: In function ‘nettoe_term_set_color’:
terminal.c:194:33: warning: ‘%d’ directive writing between 1 and 11 bytes into a region of size between 0 and 9 [-Wformat-overflow=]
  194 |         sprintf(cmd_str, "%c[%d;%dm", 0x1B, attrib, fg + 30);
      |                                 ^~
terminal.c:194:26: note: directive argument in the range [-2147483618, 2147483647]
  194 |         sprintf(cmd_str, "%c[%d;%dm", 0x1B, attrib, fg + 30);
      |                          ^~~~~~~~~~~
In file included from /usr/include/stdio.h:867,
                 from terminal.c:26:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 7 and 27 bytes into a destination of size 13
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mv -f .deps/terminal.Tpo .deps/terminal.Po
gcc -DNETTOE_PORT=7501 -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -MT misc.o -MD -MP -MF .deps/misc.Tpo -c -o misc.o misc.c
mv -f .deps/misc.Tpo .deps/misc.Po
gcc -DNETTOE_PORT=7501 -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -MT network.o -MD -MP -MF .deps/network.Tpo -c -o network.o network.c
mv -f .deps/network.Tpo .deps/network.Po
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security  -Wl,-z,relro -o nettoe ai.o board.o nettoe.o matrices.o terminal.o misc.o network.o -ltinfo 
/usr/bin/ld: terminal.o:./src/game.h:48: multiple definition of `NO_COLORS'; nettoe.o:./src/game.h:48: first defined here
/usr/bin/ld: terminal.o:./src/game.h:46: multiple definition of `NO_BEEP'; nettoe.o:./src/game.h:46: first defined here
/usr/bin/ld: terminal.o:./src/game.h:50: multiple definition of `addrfamily'; nettoe.o:./src/game.h:50: first defined here
/usr/bin/ld: misc.o:./src/game.h:50: multiple definition of `addrfamily'; nettoe.o:./src/game.h:50: first defined here
/usr/bin/ld: misc.o:./src/game.h:48: multiple definition of `NO_COLORS'; nettoe.o:./src/game.h:48: first defined here
/usr/bin/ld: misc.o:./src/game.h:46: multiple definition of `NO_BEEP'; nettoe.o:./src/game.h:46: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:371: nettoe] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:398: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:339: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:8: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2