Bug#957671: pcsxr: ftbfs with GCC-10

[Matthias Klose]

Package: src:pcsxr
Version: 1.9.94-4
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/pcsxr_1.9.94-4_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ConfDlg.c: In function ‘OnConf_Sio1’:
ConfDlg.c:308:22: warning: ‘%s’ directive writing up to 4095 bytes into a region of size between 0 and 4095 [-Wformat-overflow=]
  308 |  sprintf(Plugin, "%s/%s", Config.PluginsDir, Config.Sio1);
      |                      ^~                      ~~~~~~~~~~~
In file included from /usr/include/stdio.h:867,
                 from ConfDlg.c:19:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 2 and 8192 bytes into a destination of size 4096
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ConfDlg.c: In function ‘OnConf_Pad’:
ConfDlg.c:329:22: warning: ‘%s’ directive writing up to 4095 bytes into a region of size between 0 and 4095 [-Wformat-overflow=]
  329 |  sprintf(Plugin, "%s/%s", Config.PluginsDir, Config.Pad1);
      |                      ^~                      ~~~~~~~~~~~
In file included from /usr/include/stdio.h:867,
                 from ConfDlg.c:19:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 2 and 8192 bytes into a destination of size 4096
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ConfDlg.c:345:23: warning: ‘%s’ directive writing up to 4095 bytes into a region of size between 0 and 4095 [-Wformat-overflow=]
  345 |   sprintf(Plugin, "%s/%s", Config.PluginsDir, Config.Pad2);
      |                       ^~                      ~~~~~~~~~~~
In file included from /usr/include/stdio.h:867,
                 from ConfDlg.c:19:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 2 and 8192 bytes into a destination of size 4096
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ConfDlg.c: In function ‘FindNetPlugin’:
ConfDlg.c:807:24: warning: ‘%s’ directive writing up to 255 bytes into a region of size between 0 and 4095 [-Wformat-overflow=]
  807 |    sprintf(plugin, "%s/%s", Config.PluginsDir, ent->d_name);
      |                        ^~
In file included from /usr/include/stdio.h:867,
                 from ConfDlg.c:19:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 2 and 4352 bytes into a destination of size 4096
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/bin/bash ../libtool  --tag=CC   --mode=link gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security  -specs=/usr/share/dpkg/no-pie-link.specs -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o pcsxr LnxMain.o Plugin.o Config.o GtkGui.o MemcardDlg.o ConfDlg.o Cheat.o DebugMemory.o AboutDlg.o ../libpcsxcore/libpcsxcore.a -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lpthread -lz -lm -lXext -lXtst -ldl -lnsl
libtool: link: gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -specs=/usr/share/dpkg/no-pie-link.specs -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,--as-needed -o pcsxr LnxMain.o Plugin.o Config.o GtkGui.o MemcardDlg.o ConfDlg.o Cheat.o DebugMemory.o AboutDlg.o  ../libpcsxcore/libpcsxcore.a -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lpthread -lz -lm -lXext -lXtst -ldl -lnsl
/usr/bin/ld: Plugin.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: Plugin.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
/usr/bin/ld: Config.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
/usr/bin/ld: Config.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: GtkGui.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: GtkGui.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
/usr/bin/ld: MemcardDlg.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: MemcardDlg.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
/usr/bin/ld: ConfDlg.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: ConfDlg.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
/usr/bin/ld: Cheat.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: Cheat.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
/usr/bin/ld: DebugMemory.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: DebugMemory.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
/usr/bin/ld: AboutDlg.o:./gui/Linux.h:43: multiple definition of `cfgfile_basename'; LnxMain.o:./gui/Linux.h:43: first defined here
/usr/bin/ld: AboutDlg.o:./gui/Linux.h:42: multiple definition of `cfgfile'; LnxMain.o:./gui/Linux.h:42: first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:469: pcsxr] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/gui'
make[1]: *** [Makefile:449: all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:7: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2