Bug#957807: slashem: ftbfs with GCC-10

[Matthias Klose]

Package: src:slashem
Version: 0.0.7E7F3-9
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/slashem_0.0.7E7F3-9_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
../win/proxy/prxyconn.c:221:9: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  221 |   write((int)wfd, buffer, nb);
      |         ^
In file included from /usr/include/x86_64-linux-gnu/sys/types.h:179,
                 from /usr/include/stdlib.h:394,
                 from ../win/proxy/prxyconn.c:5:
../win/proxy/prxyconn.c:223:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  223 |  if (FD_ISSET((int)rfd, &readfds)) {
      |               ^
../win/proxy/prxyconn.c:223:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  223 |  if (FD_ISSET((int)rfd, &readfds)) {
      |               ^
../win/proxy/prxyconn.c:224:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  224 |      nb = read((int)rfd, buffer, sizeof(buffer));
      |                ^
../win/proxy/prxyconn.c: In function ‘client_read’:
../win/proxy/prxyconn.c:239:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  239 |     nb = read((int)handle, buf, len);
      |               ^
../win/proxy/prxyconn.c: In function ‘client_write’:
../win/proxy/prxyconn.c:247:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  247 |     nb = write((int)handle, buf, len);
      |                ^
../win/proxy/prxyconn.c: In function ‘proxy_connect_file’:
../win/proxy/prxyconn.c:574:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  574 |  return proxy_init_client_services(client_read, (void *)from_game[0],
      |                                                 ^
../win/proxy/prxyconn.c:575:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  575 |    client_write, (void *)to_game[1]);
      |                  ^
../win/proxy/prxyconn.c: In function ‘proxy_connect_tcp’:
../win/proxy/prxyconn.c:611:13: warning: implicit declaration of function ‘inet_addr’ [-Wimplicit-function-declaration]
  611 |     iaddr = inet_addr(s);
      |             ^~~~~~~~~
../win/proxy/prxyconn.c:629:52: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  629 |     return proxy_init_client_services(client_read, (void *)skt,
      |                                                    ^
../win/proxy/prxyconn.c:630:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  630 |       client_write, (void *)skt);
      |                     ^
cc -DDEBIAN_GTK -g -O2 -fomit-frame-pointer -fstack-protector --param=ssp-buffer-size=4 -I../include -I/usr/X11R6/include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o version.o version.c
Loading ...
cc -L/usr/X11R6/lib -Wl,-z,relro -o slashem monst.o objects.o alloc.o allmain.o apply.o artifact.o attrib.o ball.o bones.o botl.o cmd.o dbridge.o decl.o detect.o dig.o display.o dlb.o do.o do_name.o do_wear.o dog.o dogmove.o dokick.o dothrow.o drawing.o dungeon.o eat.o end.o engrave.o exper.o explode.o extralev.o files.o fountain.o hack.o hacklib.o invent.o light.o lock.o mail.o makemon.o mapglyph.o mcastu.o mhitm.o mhitu.o minion.o mklev.o mkmap.o mkmaze.o mkobj.o mkroom.o mon.o mondata.o monmove.o monstr.o mplayer.o mthrowu.o muse.o music.o o_init.o objnam.o options.o pager.o pickup.o pline.o polyself.o potion.o pray.o priest.o quest.o questpgr.o read.o rect.o region.o restore.o rip.o rnd.o role.o rumors.o save.o shk.o shknam.o sit.o sounds.o sp_lev.o spell.o steal.o steed.o teleport.o timeout.o topten.o track.o trap.o u_init.o uhitm.o vault.o vision.o vis_tab.o weapon.o were.o wield.o windows.o wizard.o worm.o worn.o write.o zap.o gypsy.o tech.o  ioctl.o unixmain.o unixtty.o unixunix.o unixres.o getline.o termcap.o topl.o wintty.o  gtk.o gtkgetlin.o gtkstatus.o gtkmenu.o gtkyn.o gtkextcmd.o gtkmap.o gtktile.o gtkmessage.o gtkmisc.o xshmmap.o gtkhackrc.o gtkprefs.o gtkprogress.o gtkext.o gtkint.o nhwin.a winproxy.o callback.o nhwin.a dlbh.o mapid.o riputil.o getopt.o glyphmap.o nhext.o nhxdr.o nhextxdr.o nhextio.o nhextnb.o compxdr.o proxysvc.o proxycb.o prxymap.o prxychar.o prxytile.o prxyconn.o version.o -lncurses `PKG_CONFIG_PATH=/usr/devel/lib/pkgconfig pkg-config gtk+-2.0 --libs` -lpthread  -lm
/usr/bin/ld: gtkgetlin.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkstatus.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkmenu.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkyn.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkextcmd.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkmap.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtktile.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkmessage.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkmisc.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: xshmmap.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkhackrc.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkprefs.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkprogress.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkext.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: gtkint.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: multiple definition of `copts'; gtk.o:/<<PKGBUILDDIR>>/src/../include/winGTK.h:253: first defined here
/usr/bin/ld: nhwin.a(tile.o):/<<PKGBUILDDIR>>/src/tile.c:764: multiple definition of `tiles_per_col'; gtktile.o:/<<PKGBUILDDIR>>/src/../win/gtk/gtktile.c:26: first defined here
/usr/bin/ld: nhwin.a(tile.o):/<<PKGBUILDDIR>>/src/tile.c:763: multiple definition of `tiles_per_row'; gtktile.o:/<<PKGBUILDDIR>>/src/../win/gtk/gtktile.c:25: first defined here
/usr/bin/ld: nhwin.a(tile.o):/<<PKGBUILDDIR>>/src/tile.c:762: multiple definition of `total_tiles_used'; gtktile.o:/<<PKGBUILDDIR>>/src/../win/gtk/gtktile.c:24: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:565: Sysunix] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:150: slashem] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:36: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:4: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2