Bug#957972: xboard: ftbfs with GCC-10

[Matthias Klose]

Package: src:xboard
Version: 4.9.1-1
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/xboard_4.9.1-1_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from gtk/xengineoutput.c:52:
/usr/include/glib-2.0/gobject/gtype.h:679:1: note: declared here
  679 | {
      | ^
In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
                 from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
                 from /usr/include/gtk-2.0/gtk/gtk.h:126,
                 from gtk/xengineoutput.c:52:
/usr/include/gtk-2.0/gtk/gtktooltips.h:73:3: warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
   73 |   GTimeVal last_popdown;
      |   ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/glib-2.0/gobject/gbinding.h:28,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from gtk/xengineoutput.c:52:
/usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
  551 | struct _GTimeVal
      |        ^~~~~~~~~
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wno-parentheses  -Wl,-z,relro -Wl,-z,now -o xboard backend.o book.o childio.o gamelist.o ngamelist.o lists.o moves.o parser.o pgntags.o uci.o board.o draw.o dialogs.o engineoutput.o nengineoutput.o evalgraph.o nevalgraph.o history.o nhistory.o menus.o usounds.o usystem.o zippy.o gtk/xboard.o gtk/xoptions.o gtk/xtimer.o gtk/xengineoutput.o -ldl -lm -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lfontconfig -lfreetype -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0   -lpangocairo-1.0 -lpango-1.0 -lrsvg-2 -lm -lgio-2.0 -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 -lcairo 
/usr/bin/ld: book.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: childio.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: gamelist.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: ngamelist.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: moves.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: parser.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: pgntags.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: uci.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: board.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: draw.o:./evalgraph.h:37: multiple definition of `currPvInfo'; backend.o:./evalgraph.h:37: first defined here
/usr/bin/ld: draw.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: dialogs.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: engineoutput.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: nengineoutput.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: evalgraph.o:./evalgraph.h:37: multiple definition of `currPvInfo'; backend.o:./evalgraph.h:37: first defined here
/usr/bin/ld: evalgraph.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: nevalgraph.o:./evalgraph.h:37: multiple definition of `currPvInfo'; backend.o:./evalgraph.h:37: first defined here
/usr/bin/ld: nevalgraph.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: history.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: nhistory.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: menus.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: usystem.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: zippy.o:./backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: gtk/xboard.o:././backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: gtk/xoptions.o:././backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: gtk/xtimer.o:././backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
/usr/bin/ld: gtk/xengineoutput.o:././backend.h:245: multiple definition of `ics_type'; backend.o:./backend.h:245: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:803: xboard] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:1168: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:672: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:6: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2