Bug#966885: spring: FTBFS: SHA512.cpp:25:3: error: ‘snprintf’ was not declared in this scope

[Lucas Nussbaum]

Source: spring
Version: 104.0+dfsg-6
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20200802 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/rts/builds/legacy && /usr/bin/c++  -DASIO_STANDALONE -DBOOST_ALL_NO_LIB -DBOOST_NO_FENV_H -DBOOST_REGEX_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DSPRING_DATADIR=\"/usr/share/games/spring:/usr/lib/spring\" -DSTREFLOP_SSE -DSYNCCHECK -DTHREADPOOL -DUSE_LIBSQUISH -D_GLIBCXX_USE_NANOSLEEP -D_RANDOM_TCC -I/<<PKGBUILDDIR>>/rts/lib/lua/include -I/<<PKGBUILDDIR>>/include/AL -I/<<PKGBUILDDIR>>/rts -I/<<PKGBUILDDIR>>/rts/lib/assimp/include -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src-generated/engine -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/rts/lib/gflags/include -I/usr/include/SDL2 -I/usr/include/freetype2 -I/usr/include/AL -I/<<PKGBUILDDIR>>/rts/lib/asio/include -I/<<PKGBUILDDIR>>/rts/lib/slimsig/include  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -std=gnu++11 -fdiagnostics-color=auto -mtune=generic -msse -mfpmath=sse -mno-sse2 -mno-sse3 -mno-ssse3 -mno-sse4.1 -mno-sse4.2 -mno-sse4 -mno-sse4a -mno-avx -mno-fma -mno-fma4 -mno-xop -mno-lwp -mno-avx2 -fsingle-precision-constant -frounding-math -mieee-fp -pipe -fno-strict-aliasing  -fvisibility=hidden  -fvisibility-inlines-hidden -pthread  -O2      -Wformat -Wformat-security -DNDEBUG -g   -o CMakeFiles/engine-legacy.dir/__/__/System/Platform/SharedLib.cpp.o -c /<<PKGBUILDDIR>>/rts/System/Platform/SharedLib.cpp
> /<<PKGBUILDDIR>>/rts/System/Sync/SHA512.cpp: In function ‘void sha512::dump_digest(const std::array<unsigned char, 64>&, std::array<char, 129>&)’:
> /<<PKGBUILDDIR>>/rts/System/Sync/SHA512.cpp:25:3: error: ‘snprintf’ was not declared in this scope
>    25 |   snprintf(hex_chars.data() + (i * 2), hex_chars.size() - (i * 2), "%02x", sha_bytes[i]);
>       |   ^~~~~~~~
> /<<PKGBUILDDIR>>/rts/System/Sync/SHA512.cpp:7:1: note: ‘snprintf’ is defined in header ‘<cstdio>’; did you forget to ‘#include <cstdio>’?
>     6 | #include "SHA512.hpp"
>   +++ |+#include <cstdio>
>     7 | 
> make[4]: *** [rts/builds/headless/CMakeFiles/engine-headless.dir/build.make:4174: rts/builds/headless/CMakeFiles/engine-headless.dir/__/__/System/Sync/SHA512.cpp.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/08/02/spring_104.0+dfsg-6_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.