2 patches for the Debian scorched3d package

Bruno Kleinert fuddl at debian.org
Mon Aug 31 03:43:06 BST 2020


Am Donnerstag, den 13.08.2020, 22:35 +0200 schrieb Hans de Goede:
> Hi,
> 
> I'm the maintainer of scorched3d in Fedora. Attached are
> 2 patches for scorched3d which I would like to share to
> avoid you doing double work.
> 
> While rebuilding scorched3d against lua-5.4 for Fedora-33
> I had to do a small fix for lua-5.4 compat. That is the first
> attached patch, this patch is also safe to use with older lua
> versions. Hmm, I just realize that IIRC the Debian package uses
> the bundled lua instead of using the system version of lua.
> So I've also attached Fedora's patch for unbundling lua
> and using the system-wide installed lua-lib instead.
> 
> Then while testing single player games would hang at
> the beginning of the first game round. Pinning this down
> took me an entire day of debugging, it is a timing issue
> which only happens on pretty fast machines.
> 
> The second patch works around this, I'm afraid I could not
> come up with a better fix. Still you probably want to apply
> this, as otherwise single player scorched3d is unusable on
> fast machines.
> 
> I've mailed Gavin Camp (the original scorched3d author)
> about the timing issue, but he has not touched scorched3d
> in many years, so...
> 
> Regards,
> 
> Hans

Hi Hans,

many thanks for letting us know! I applied the patches for Lua 5.4 and
the workaround against the race condition unmodified.

The patch to build against the system-wide installed Lua I modified
since it seems that it modified generated files. Instead, I added a
pkg-config check for lua to the auto*-tools configuration files. I
admit, I'm not 100% sure if that is perfectly correct.

Cheers,
Bruno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/pkg-games-devel/attachments/20200831/53d31a7c/attachment.sig>


More information about the Pkg-games-devel mailing list