Bug#950859: cegui-mk2: FTBFS with boost171 and new cmake and symbol changes

[Dimitri John Ledkov]

Package: cegui-mk2
Version: 0.8.7-5
Severity: serious
Tags: patch
Justification: ftbfs

Dear Maintainer,

cegui-mk2 ftbfs with new cmake & boost1.71 due to change in cmake
policy w.r.t. boost version detection (it is now more normal). See patch attached.

I am currently in process of migrating to boost1.71 in Ubuntu, which
has not started yet in Debian but is upcoming.

When built against boost1.71 symbols are dropped and changed. It seems
as if cegui-mk2 re-exports boost symbols, and thus boost abi change in
templates leakes in the change of cegui-mk2 libraries ABI change.

How should this be handled?

Is there a new upstream release of cegui that we can package in
experimental, always built against boost1.71 with new symbols?

Or shall i just blindly update the symbols file, rebuild ember and
hope for the best?

How was this handled in cegui-mk2 before, when boost changed without
cegui-mk2 new upstream releases?

I would like to avoid diverging ABI between ubuntu & debian here.

Regards,

Dimitri.
-------------- next part --------------
diff -Nru cegui-mk2-0.8.7/debian/changelog cegui-mk2-0.8.7/debian/changelog
--- cegui-mk2-0.8.7/debian/changelog	2020-02-03 20:02:21.000000000 +0000
+++ cegui-mk2-0.8.7/debian/changelog	2020-02-06 22:17:46.000000000 +0000
@@ -1,3 +1,10 @@
+cegui-mk2 (0.8.7-5ubuntu3) focal; urgency=medium
+
+  * Patch CMakeLists for new Boost_VERSION syntax.
+  * Drop unused boost signals dependencies.
+
+ -- Dimitri John Ledkov <xnox at ubuntu.com>  Thu, 06 Feb 2020 22:17:46 +0000
+
 cegui-mk2 (0.8.7-5ubuntu2) focal; urgency=medium
 
   * No change rebuild against new boost1.71 ABI
diff -Nru cegui-mk2-0.8.7/debian/control cegui-mk2-0.8.7/debian/control
--- cegui-mk2-0.8.7/debian/control	2020-02-03 20:02:21.000000000 +0000
+++ cegui-mk2-0.8.7/debian/control	2020-02-06 22:16:26.000000000 +0000
@@ -14,7 +14,6 @@
                libboost-dev,
                libboost-python-dev,
                libboost-regex-dev,
-               libboost-signals-dev,
                libdevil-dev,
                libexpat1-dev,
                libfreeimage-dev,
diff -Nru cegui-mk2-0.8.7/debian/patches/boost-version.patch cegui-mk2-0.8.7/debian/patches/boost-version.patch
--- cegui-mk2-0.8.7/debian/patches/boost-version.patch	1970-01-01 00:00:00.000000000 +0000
+++ cegui-mk2-0.8.7/debian/patches/boost-version.patch	2020-02-06 22:17:46.000000000 +0000
@@ -0,0 +1,15 @@
+Description: Patch CMakeLists for new Boost_VERSION syntax.
+Author: Dimitri John Ledkov <xnox at ubuntu.com>
+
+
+--- cegui-mk2-0.8.7.orig/CMakeLists.txt
++++ cegui-mk2-0.8.7/CMakeLists.txt
+@@ -121,7 +121,7 @@ find_package(TOLUAPP)
+ 
+ find_package(Python3 COMPONENTS Interpreter Development)
+ find_package(Boost)
+-if(${Boost_VERSION} GREATER_EQUAL 106700)
++if(${Boost_VERSION} GREATER_EQUAL 1.67)
+     if (Python3_FOUND)
+         set(CEGUI_PYTHON3_VERSION_NUM ${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR})
+         find_package(Boost COMPONENTS python${CEGUI_PYTHON3_VERSION_NUM})
diff -Nru cegui-mk2-0.8.7/debian/patches/series cegui-mk2-0.8.7/debian/patches/series
--- cegui-mk2-0.8.7/debian/patches/series	2019-09-30 02:11:30.000000000 +0000
+++ cegui-mk2-0.8.7/debian/patches/series	2020-02-06 22:17:46.000000000 +0000
@@ -8,3 +8,4 @@
 relative_paths.patch
 jura_fonts.patch
 futhark_font.patch
+boost-version.patch