Bug#953016: fife: FTBFS after avoiding #951962: swig4.0: Deprecated command line option: -nosafecstrings. This option is no longer supported.

[Simon McVittie]

Source: fife
Version: 0.4.2-1
Severity: serious
Tags: ftbfs bullseye sid upstream
Justification: fails to build from source (but built successfully in the past)
Forwarded: https://github.com/fifengine/fifengine/issues/1074

I tried compiling fife against a libsdl2 with the patch proposed at
<https://salsa.debian.org/sdl-team/libsdl2/-/merge_requests/3>
to avoid #951962, and got a different build error:

> make[3]: Entering directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
> [  1%] Swig compile /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/fifechan.i for python
> /usr/bin/cmake -E make_directory /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/CMakeFiles/_fifechan.dir
> [  2%] Swig compile /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/fife.i for python
> /usr/bin/cmake -E make_directory /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/CMakeFiles/_fife.dir
> /usr/bin/cmake -E touch /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/CMakeFiles/_fife.dir/fifePYTHON.stamp
> /usr/bin/cmake -E touch /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/CMakeFiles/_fifechan.dir/fifechanPYTHON.stamp
> /usr/bin/cmake -E env SWIG_LIB=/usr/share/swig4.0 /usr/bin/swig4.0 -python -modern -fastdispatch -dirvtable -nosafecstrings -noproxydel -fastproxy -fastinit -fastunpack -fastquery -modernargs -nobuildnone -keyword -w511 -w473 -w404 -w314 -outdir /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -c++ -interface _fife -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/<<PKGBUILDDIR>>/engine/core -I/<<PKGBUILDDIR>> -I/usr/include -I/usr/include/SDL2 -I/usr/include/AL -I/usr/include/python3.8 -o /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/CMakeFiles/_fife.dir/fifePYTHON_wrap.cxx /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/fife.i
> /usr/bin/cmake -E env SWIG_LIB=/usr/share/swig4.0 /usr/bin/swig4.0 -python -modern -fastdispatch -dirvtable -nosafecstrings -noproxydel -fastproxy -fastinit -fastunpack -fastquery -modernargs -nobuildnone -keyword -w511 -w473 -w404 -w314 -outdir /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -c++ -interface _fifechan -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu -I/<<PKGBUILDDIR>>/engine/core -I/<<PKGBUILDDIR>> -I/usr/include -I/usr/include/SDL2 -I/usr/include/AL -I/usr/include/python3.8 -o /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/CMakeFiles/_fifechan.dir/fifechanPYTHON_wrap.cxx /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/fifechan.i
> Deprecated command line option: -modern. This option is now always on.
> Deprecated command line option: -nosafecstrings. This option is no longer supported.
> make[3]: *** [CMakeFiles/fife_swig_compilation.dir/build.make:139: CMakeFiles/_fife.dir/fifePYTHON.stamp] Error 1

>From http://www.swig.org/Release/CHANGES it appears that -nosafecstrings
was always the default anyway, so simply removing the option might be
enough. Upstream has a 'swig' branch that removes this and another
unsupported option
(<https://github.com/fifengine/fifengine/commit/d14f232f4cd9a00b05d6872957070e8c020f515d>)
but it hasn't been merged or proposed as a pull request; I don't know why.

    smcv