Bug#954722: spring: FTBFS: unistd_ext.h:34:16: error: conflicting declaration of ‘__pid_t gettid() ’ with ‘C’ linkage

[Lucas Nussbaum]

Source: spring
Version: 104.0+dfsg-5
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20200322 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/test && /usr/bin/c++  -DASIO_STANDALONE -DBOOST_NO_FENV_H -DBOOST_TEST_DYN_LINK -DSPRING_DATADIR=\"/usr/share/games/spring:/usr/lib/spring\" -DSTREFLOP_SSE -DSYNCCHECK -DUNIT_TEST -DUSE_LIBSQUISH -D_GLIBCXX_USE_NANOSLEEP -D_RANDOM_TCC -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src-generated/engine -I/<<PKGBUILDDIR>>/rts -I/<<PKGBUILDDIR>>/rts/lib/asio/include  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -std=gnu++11 -fdiagnostics-color=auto -mtune=generic -msse -mfpmath=sse -mno-sse2 -mno-sse3 -mno-ssse3 -mno-sse4.1 -mno-sse4.2 -mno-sse4 -mno-sse4a -mno-avx -mno-fma -mno-fma4 -mno-xop -mno-lwp -mno-avx2 -fsingle-precision-constant -frounding-math -mieee-fp -pipe -fno-strict-aliasing  -fvisibility=hidden  -fvisibility-inlines-hidden -pthread  -O2      -Wformat -Wformat-security -DNDEBUG -g   -DTHREADPOOL -DUNITSYNC -o CMakeFiles/test_ThreadPool.dir/engine/System/testThreadPool.cpp.o -c /<<PKGBUILDDIR>>/test/engine/System/testThreadPool.cpp
> In file included from /usr/include/unistd.h:1170,
>                  from /usr/include/boost/config/stdlib/libstdcpp3.hpp:78,
>                  from /usr/include/boost/config.hpp:49,
>                  from /usr/include/boost/thread/detail/config.hpp:11,
>                  from /usr/include/boost/thread/future.hpp:11,
>                  from /<<PKGBUILDDIR>>/test/engine/System/testThreadPool.cpp:12:
> /usr/include/x86_64-linux-gnu/bits/unistd_ext.h:34:16: error: conflicting declaration of ‘__pid_t gettid()’ with ‘C’ linkage
>    34 | extern __pid_t gettid (void) __THROW;
>       |                ^~~~~~
> In file included from /<<PKGBUILDDIR>>/rts/System/Platform/Threading.h:9,
>                  from /<<PKGBUILDDIR>>/rts/System/Threading/ThreadPool.h:66,
>                  from /<<PKGBUILDDIR>>/test/engine/System/testThreadPool.cpp:3:
> /<<PKGBUILDDIR>>/rts/System/Platform/Linux/ThreadSupport.h:24:5: note: previous declaration with ‘C++’ linkage
>    24 | int gettid ();
>       |     ^~~~~~
> In file included from /usr/include/unistd.h:1170,
>                  from /usr/include/boost/config/stdlib/libstdcpp3.hpp:78,
>                  from /usr/include/boost/config.hpp:49,
>                  from /usr/include/boost/thread/detail/config.hpp:11,
>                  from /usr/include/boost/thread/future.hpp:11,
>                  from /<<PKGBUILDDIR>>/test/engine/System/testThreadPool.cpp:12:
> /usr/include/x86_64-linux-gnu/bits/unistd_ext.h:34:16: error: declaration of ‘__pid_t gettid() throw ()’ has a different exception specifier
>    34 | extern __pid_t gettid (void) __THROW;
>       |                ^~~~~~
> In file included from /<<PKGBUILDDIR>>/rts/System/Platform/Threading.h:9,
>                  from /<<PKGBUILDDIR>>/rts/System/Threading/ThreadPool.h:66,
>                  from /<<PKGBUILDDIR>>/test/engine/System/testThreadPool.cpp:3:
> /<<PKGBUILDDIR>>/rts/System/Platform/Linux/ThreadSupport.h:24:5: note: from previous declaration ‘int gettid()’
>    24 | int gettid ();
>       |     ^~~~~~
> make[5]: *** [test/CMakeFiles/test_ThreadPool.dir/build.make:66: test/CMakeFiles/test_ThreadPool.dir/engine/System/testThreadPool.cpp.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/03/22/spring_104.0+dfsg-5_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.