Bug#983986: berusky: ftbfs with GCC-11

Wed Mar 3 16:10:45 GMT 2021

Package: src:berusky
Version: 1.7.2-1
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/berusky_1.7.2-1_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
  601 |     RECT r = {EDIT_ITEM_PICT_START_X+EDITOR_ITEM_SIZE_X+10,
In file included from berusky.h:109,
                 from editor.cpp:45:
defines.h:101:66: warning: narrowing conversion of ‘(((((berusky_config::editor_screen_start_y + berusky_config::level_resolution_y) - 140) + 20) + 20) + 10)’ from ‘int’ to ‘Sint16’ {aka ‘short int’} [-Wnarrowing]
  101 | #define EDIT_ITEM_PICT_START_Y    (EDIT_ITEM_START_Y+EDIT_ITEM_DY+10)
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
editor.cpp:602:15: note: in expansion of macro ‘EDIT_ITEM_PICT_START_Y’
  602 |               EDIT_ITEM_PICT_START_Y,
      |               ^~~~~~~~~~~~~~~~~~~~~~
editor.cpp: In member function ‘void editor_gui::layer_status_create()’:
defines.h:84:55: warning: narrowing conversion of ‘(berusky_config::editor_resolution_x - ((20 * 3) * 2))’ from ‘int’ to ‘Uint16’ {aka ‘short unsigned int’} [-Wnarrowing]
   84 | #define EDITOR_LAYER_STATUS_DX    (EDITOR_RESOLUTION_X-EDITOR_LAYER_STATUS_X)
      |                                   ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
editor.cpp:819:13: note: in expansion of macro ‘EDITOR_LAYER_STATUS_DX’
  819 |             EDITOR_LAYER_STATUS_DX,
      |             ^~~~~~~~~~~~~~~~~~~~~~
editor.cpp: In member function ‘void editor_gui::level_config()’:
defines.h:87:52: warning: narrowing conversion of ‘berusky_config::editor_screen_start_x’ from ‘int’ to ‘Sint16’ {aka ‘short int’} [-Wnarrowing]
   87 | #define EDITOR_SCREEN_START_X     (berusky_config::editor_screen_start_x)
      |                                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
editor.cpp:960:13: note: in expansion of macro ‘EDITOR_SCREEN_START_X’
  960 |   RECT r = {EDITOR_SCREEN_START_X,EDITOR_SCREEN_START_Y,LEVEL_RESOLUTION_X,LEVEL_RESOLUTION_Y};
      |             ^~~~~~~~~~~~~~~~~~~~~
defines.h:88:52: warning: narrowing conversion of ‘berusky_config::editor_screen_start_y’ from ‘int’ to ‘Sint16’ {aka ‘short int’} [-Wnarrowing]
   88 | #define EDITOR_SCREEN_START_Y     (berusky_config::editor_screen_start_y)
      |                                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
editor.cpp:960:35: note: in expansion of macro ‘EDITOR_SCREEN_START_Y’
  960 |   RECT r = {EDITOR_SCREEN_START_X,EDITOR_SCREEN_START_Y,LEVEL_RESOLUTION_X,LEVEL_RESOLUTION_Y};
      |                                   ^~~~~~~~~~~~~~~~~~~~~
defines.h:51:52: warning: narrowing conversion of ‘berusky_config::level_resolution_x’ from ‘int’ to ‘Uint16’ {aka ‘short unsigned int’} [-Wnarrowing]
   51 | #define LEVEL_RESOLUTION_X        (berusky_config::level_resolution_x)
      |                                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
editor.cpp:960:57: note: in expansion of macro ‘LEVEL_RESOLUTION_X’
  960 |   RECT r = {EDITOR_SCREEN_START_X,EDITOR_SCREEN_START_Y,LEVEL_RESOLUTION_X,LEVEL_RESOLUTION_Y};
      |                                                         ^~~~~~~~~~~~~~~~~~
defines.h:52:52: warning: narrowing conversion of ‘berusky_config::level_resolution_y’ from ‘int’ to ‘Uint16’ {aka ‘short unsigned int’} [-Wnarrowing]
   52 | #define LEVEL_RESOLUTION_Y        (berusky_config::level_resolution_y)
      |                                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
editor.cpp:960:76: note: in expansion of macro ‘LEVEL_RESOLUTION_Y’
  960 |   RECT r = {EDITOR_SCREEN_START_X,EDITOR_SCREEN_START_Y,LEVEL_RESOLUTION_X,LEVEL_RESOLUTION_Y};
      |                                                                            ^~~~~~~~~~~~~~~~~~
make[4]: *** [Makefile:553: 2d_graph.o] Error 1
make[4]: *** Waiting for unfinished jobs....
In file included from /usr/include/string.h:495,
                 from editor.cpp:31:
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘void editor_gui::level_name_set(char*)’ at editor.cpp:1033:10:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 4096 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘void editor_gui::level_load(char*, int)’ at editor.cpp:1044:14:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 4096 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘char* strncpy(char*, const char*, size_t)’,
    inlined from ‘void editor_gui::level_save_as(char*, int)’ at editor.cpp:1111:12:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 4096 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[3]: *** [Makefile:496: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:407: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make[1]: *** [debian/rules:17: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:5: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2