Bug#984275: openmw: ftbfs with GCC-11

[Matthias Klose]

Package: src:openmw
Version: 0.46.0-3
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/openmw_0.46.0-3_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                                     ^~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2837:78: note: in expansion of macro ‘dbl_max’
 2837 |     min_x_ratio = convexHull.valid() ? convexHull.minRatio(virtual_eye,0) : -dbl_max;
      |                                                                              ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:22: error: ‘numeric_limits’ is not a member of ‘std’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                      ^~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2838:77: note: in expansion of macro ‘dbl_max’
 2838 |     max_x_ratio = convexHull.valid() ? convexHull.maxRatio(virtual_eye,0) : dbl_max;
      |                                                                             ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:37: error: expected primary-expression before ‘double’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                                     ^~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2838:77: note: in expansion of macro ‘dbl_max’
 2838 |     max_x_ratio = convexHull.valid() ? convexHull.maxRatio(virtual_eye,0) : dbl_max;
      |                                                                             ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:22: error: ‘numeric_limits’ is not a member of ‘std’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                      ^~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2882:28: note: in expansion of macro ‘dbl_max’
 2882 |         if (min_z_ratio == dbl_max || rli.min_z_ratio > min_z_ratio)
      |                            ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:37: error: expected primary-expression before ‘double’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                                     ^~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2882:28: note: in expansion of macro ‘dbl_max’
 2882 |         if (min_z_ratio == dbl_max || rli.min_z_ratio > min_z_ratio)
      |                            ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:37: error: expected ‘)’ before ‘double’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                                     ^~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2882:28: note: in expansion of macro ‘dbl_max’
 2882 |         if (min_z_ratio == dbl_max || rli.min_z_ratio > min_z_ratio)
      |                            ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2882:12: note: to match this ‘(’
 2882 |         if (min_z_ratio == dbl_max || rli.min_z_ratio > min_z_ratio)
      |            ^
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:22: error: ‘numeric_limits’ is not a member of ‘std’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                      ^~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2884:29: note: in expansion of macro ‘dbl_max’
 2884 |         if (max_z_ratio == -dbl_max || rli.max_z_ratio < max_z_ratio)
      |                             ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:37: error: expected primary-expression before ‘double’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                                     ^~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2884:29: note: in expansion of macro ‘dbl_max’
 2884 |         if (max_z_ratio == -dbl_max || rli.max_z_ratio < max_z_ratio)
      |                             ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:33:37: error: expected ‘)’ before ‘double’
   33 | #define dbl_max std::numeric_limits<double>::max()
      |                                     ^~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2884:29: note: in expansion of macro ‘dbl_max’
 2884 |         if (max_z_ratio == -dbl_max || rli.max_z_ratio < max_z_ratio)
      |                             ^~~~~~~
/<<PKGBUILDDIR>>/components/sceneutil/mwshadowtechnique.cpp:2884:12: note: to match this ‘(’
 2884 |         if (max_z_ratio == -dbl_max || rli.max_z_ratio < max_z_ratio)
      |            ^
make[3]: *** [components/CMakeFiles/components.dir/build.make:702: components/CMakeFiles/components.dir/sceneutil/shadow.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [components/CMakeFiles/components.dir/build.make:715: components/CMakeFiles/components.dir/sceneutil/mwshadowtechnique.cpp.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/build'
make[2]: *** [CMakeFiles/Makefile2:788: components/CMakeFiles/components.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/build'
make[1]: *** [Makefile:149: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/build'
dh_auto_build: error: cd build && make -j4 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:48: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2