Bug#984319: ri-li: ftbfs with GCC-11

Wed Mar 3 16:17:05 GMT 2021

Package: src:ri-li
Version: 2.0.1+ds-10
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/ri-li_2.0.1+ds-10_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking math.h usability... yes
checking math.h presence... yes
checking for math.h... yes
checking SDL/SDL.h usability... yes
checking SDL/SDL.h presence... yes
checking for SDL/SDL.h... yes
checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking SDL/SDL_mixer.h usability... yes
checking SDL/SDL_mixer.h presence... yes
checking for SDL/SDL_mixer.h... yes
checking for sqrt... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating data/Makefile
config.status: creating Sounds/Makefile
config.status: creating gentoo/Makefile
config.status: creating config.h
config.status: executing depfiles commands
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_auto_build-arch
make[1]: Entering directory '/<<PKGBUILDDIR>>'
I: ri-li_2.0.1+ds
dh_auto_build -Dsrc
	cd src && make -j4 "INSTALL=install --strip-program=true"
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o audio.o audio.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o ecran.o ecran.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o editeur.o editeur.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o jeux.o jeux.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o loco.o loco.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o main.o main.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o menu.o menu.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o mouse.o mouse.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o sprite.o sprite.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o tableau.o tableau.cc
g++ -DHAVE_CONFIG_H -I. -I..  -DDATA_DIR="\"/usr/share/games/ri-li/Ri-li\"" -Wno-deprecated -Wdate-time -D_FORTIFY_SOURCE=2 -DLINUX  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o utils.o utils.cc
sprite.cc: In member function ‘bool Sprite::Load(unsigned char*, long int&)’:
sprite.cc:355:16: error: ordered comparison of pointer with integer zero (‘SDL_Surface*’ and ‘long int’)
  355 |     if(Image[i]<=NULL) {
      |                ^
sprite.cc: In member function ‘bool Sprite::Nouveau(int, int)’:
sprite.cc:489:14: error: ordered comparison of pointer with integer zero (‘SDL_Surface*’ and ‘long int’)
  489 |   if(Image[0]<=NULL) {
      |              ^
tableau.cc: In member function ‘bool Tableau::Save()’:
tableau.cc:91:9: error: ordered comparison of pointer with integer zero (‘unsigned char*’ and ‘int’)
   91 |   if(Buf<=0) return false;
      |      ~~~^~~
make[2]: *** [Makefile:385: sprite.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:385: tableau.o] Error 1
utils.cc: In function ‘long int ChargeFichier(const char*, unsigned char*&)’:
utils.cc:119:10: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  119 |     fread(Po,1,(unsigned int)Compt,file);
      |     ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
dh_auto_build: error: cd src && make -j4 "INSTALL=install --strip-program=true" returned exit code 2
make[1]: *** [debian/rules:31: override_dh_auto_build-arch] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:12: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2