Bug#985403: bam FTCBFS -- multiple reasons

[Nilesh Patra]

Package: bam
Version: 0.5.1-2
Severity: normal
X-Debbugs-Cc: nilesh at debian.org, debian-cross at lists.debian.org

Hi,

bam currently FTCBFS due to two reasons:
	* It uses python3 as B-D which is not satisfiable during crosss
	builds. Annotating with :any does the trick here
	* It's main script: make_unix.sh hardcodes pkg-config as well as
	CC as cc by default.

The patch attached with the mail fixes it, please consider applying.

Nilesh

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages bam depends on:
ii  libc6  2.31-3

bam recommends no packages.

bam suggests no packages.
-------------- next part --------------
diff --git a/debian/control b/debian/control
index 3c064c4..3bb0e74 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: devel
 Priority: optional
 Maintainer: Debian Games Team <pkg-games-devel at lists.alioth.debian.org>
 Uploaders: Felix Geyer <fgeyer at debian.org>
-Build-Depends: debhelper-compat (= 12), graphviz, python3, liblua5.3-dev, pkg-config
+Build-Depends: debhelper-compat (= 12), graphviz, python3:any, liblua5.3-dev, pkg-config
 Standards-Version: 4.2.1
 Homepage: https://matricks.github.com/bam/
 Vcs-Git: https://salsa.debian.org/games-team/bam.git
diff --git a/debian/patches/cross.patch b/debian/patches/cross.patch
new file mode 100644
index 0000000..edd0c4b
--- /dev/null
+++ b/debian/patches/cross.patch
@@ -0,0 +1,15 @@
+Description: Do not hardcode pkg-config, build the needed file with build arch compiler
+Author: Nilesh Patra <nilesh at debian.org>
+Last-Update: 2021-03-17
+--- a/make_unix.sh
++++ b/make_unix.sh
+@@ -25,7 +25,7 @@
+ 
+ # the actual compile
+ echo "compiling using $CC..." >&2
+-$CC -Wall -pedantic $CFLAGS $CPPFLAGS $LDFLAGS src/tools/txt2c.c `pkg-config --cflags lua5.3` -o src/tools/txt2c
++$CC_FOR_BUILD -Wall -pedantic $CFLAGS $CPPFLAGS $LDFLAGS src/tools/txt2c.c `$PKG_CONFIG --cflags lua5.3` -o src/tools/txt2c
+ src/tools/txt2c src/base.lua src/tools.lua src/driver_gcc.lua src/driver_clang.lua src/driver_cl.lua src/driver_solstudio.lua src/driver_xlc.lua > src/internal_base.h
+-$CC -Wall -pedantic $CFLAGS $CPPFLAGS $LDFLAGS src/*.c src/lua/*.c -o bam `pkg-config --cflags --libs lua5.3` -lm -lpthread -ldl -rdynamic $*
++$CC -Wall -pedantic $CFLAGS $CPPFLAGS $LDFLAGS src/*.c src/lua/*.c -o bam `$PKG_CONFIG --cflags --libs lua5.3` -lm -lpthread -ldl -rdynamic $*
+ 
diff --git a/debian/patches/series b/debian/patches/series
index e2f8045..be8242b 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ reproducible-build.patch
 gendocs.patch
 make_unix.patch
 python3.patch
+cross.patch
diff --git a/debian/rules b/debian/rules
index d67d932..61af264 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,6 +2,7 @@
 
 DPKG_EXPORT_BUILDFLAGS = 1
 -include /usr/share/dpkg/buildflags.mk
+include /usr/share/dpkg/buildtools.mk
 
 %:
 	dh $@
@@ -10,7 +11,7 @@ override_dh_auto_configure:
 	# nothing to do
 
 override_dh_auto_build:
-	sh make_unix.sh
+	CC_FOR_BUILD=$(CC_FOR_BUILD) CC=$(CC) PKG_CONFIG=$(PKG_CONFIG) sh make_unix.sh
 	python3 scripts/gendocs.py
 
 override_dh_auto_install: