Bug#995597: FTBFS: error: format not a string literal and no format arguments

[Adam Borowski]

Source: bsdgames
Version: 2.17-28
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Hi!
I'm afraid that your package fails to build:

canfield/canfield/canfield.c: In function ‘instruct’:
canfield/canfield/canfield.c:1650:3: error: format not a string literal and no format arguments [-Werror=format-security]
 1650 |   printw(*cp);
      |   ^~~~~~
canfield/canfield/canfield.c:1663:3: error: format not a string literal and no format arguments [-Werror=format-security]
 1663 |   printw(*cp);
      |   ^~~~~~

The obvious fix is to either add "%s" or use a function that doesn't do formatting.


Meow!
-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (120, 'experimental'), (1, 'experimental-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-rc2-00041-g794e5d9c562d (SMP w/64 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)