Bug#1017801: openmw: hangs at start (ffmpeg-5 related)

[IOhannes m zmoelnig]

Package: openmw
Version: 0.47.0-1
Severity: important
Tags: upstream patch

Dear Maintainer,

When launching Morrowind with openmw, the game starts and you eventually come to
the initial game menu.
Clicking any item in the menu will freeze the game window.
The music keeps playing and the system stays otherwise reactive.

This is a known problem due to a bug in openmw that is triggered by ffmpeg-5.
The upstream bug-report can be found here:
  https://gitlab.com/OpenMW/openmw/-/issues/6631

Upstream also has a fix, which I attach.

-- System Information:
Debian Release: bookworm/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.18.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages openmw depends on:
ii  libavcodec59                    7:5.1-2+b1
ii  libavformat59                   7:5.1-2+b1
ii  libavutil57                     7:5.1-2+b1
ii  libboost-filesystem1.74.0       1.74.0-16.1+b1
ii  libboost-iostreams1.74.0        1.74.0-16.1+b1
ii  libboost-program-options1.74.0  1.74.0-16.1+b1
ii  libbullet3.06                   3.06+dfsg-4+b1
ii  libc6                           2.34-4
ii  libgcc-s1                       12.1.0-8
ii  libgl1                          1.4.0-1
ii  liblz4-1                        1.9.3-2
ii  libmyguiengine3debian1v5        3.4.1+dfsg-1
ii  libopenal1                      1:1.19.1-2
ii  libopenscenegraph161            3.6.5+dfsg1-7+b5
ii  libopenthreads21                3.6.5+dfsg1-7+b5
ii  librecast1                      1.5.1+git20210215.e75adf8-1+b1
ii  libsdl2-2.0-0                   2.0.22+dfsg-6
ii  libstdc++6                      12.1.0-8
ii  libswresample4                  7:5.1-2+b1
ii  libswscale6                     7:5.1-2+b1
ii  libtinyxml2.6.2v5               2.6.2-6
ii  openmw-data                     0.47.0-1

Versions of packages openmw recommends:
ii  openmw-launcher  0.47.0-1

openmw suggests no packages.

-- no debconf information
-------------- next part --------------
Description: Fix video hang with ffmpeg-5
Author: Dominique Martinet <asmadeus at codewreck.org>
Origin: upstream
Applied-Upstream: https://gitlab.com/OpenMW/openmw/-/commit/436db8c0e55b0d5be43df982d15025ed0fc76c40
Last-Update: 2022-08-20
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- openmw.orig/apps/openmw/mwsound/ffmpeg_decoder.cpp
+++ openmw/apps/openmw/mwsound/ffmpeg_decoder.cpp
@@ -18,11 +18,15 @@
         std::istream& stream = *static_cast<FFmpeg_Decoder*>(user_data)->mDataStream;
         stream.clear();
         stream.read((char*)buf, buf_size);
-        return stream.gcount();
+        std::streamsize count = stream.gcount();
+        if (count == 0)
+            return AVERROR_EOF;
+        return count;
+
     }
     catch (std::exception& )
     {
-        return 0;
+        return AVERROR_UNKNOWN;
     }
 }