Bug#1013065: warzone2100: ftbfs with GCC-12

[Matthias Klose]

Package: src:warzone2100
Version: 4.2.7-1
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-12

[This bug is targeted to the upcoming bookworm release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-12/g++-12, but succeeds to build with gcc-11/g++-11. The
severity of this report will be raised before the bookworm release.

The full build log can be found at:
http://qa-logs.debian.net/2022/06/09/gcc12/warzone2100_4.2.7-1_unstable_gcc12.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
[81/389] Building CXX object lib/framework/CMakeFiles/framework.dir/wztime.cpp.o
[82/389] Building CXX object lib/framework/CMakeFiles/framework.dir/wzpaths.cpp.o
[83/389] Building CXX object lib/gamelib/CMakeFiles/gamelib.dir/audp_lexer.cpp.o
[84/389] Building CXX object lib/gamelib/CMakeFiles/gamelib.dir/audp_parser.cpp.o
[85/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/3rdparty/stb_image_resize.cpp.o
[86/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/gfx_api.cpp.o
[87/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/gfx_api_vk.cpp.o
[88/389] Building CXX object lib/framework/CMakeFiles/framework.dir/wzstring.cpp.o
[89/389] Building CXX object lib/gamelib/CMakeFiles/gamelib.dir/gtime.cpp.o
[90/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/jpeg_encoder.cpp.o
[91/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/pieclip.cpp.o
[92/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/gfx_api_null.cpp.o
[93/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/bitimage.cpp.o
[94/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/imdload.cpp.o
[95/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/piematrix.cpp.o
[96/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/piefunc.cpp.o
[97/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/pieblitfunc.cpp.o
[98/389] Building CXX object lib/framework/CMakeFiles/framework.dir/debug.cpp.o
[99/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/piepalette.cpp.o
[100/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/piestate.cpp.o
[101/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/piemode.cpp.o
[102/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/png_util.cpp.o
[103/389] Generating netplay_config.h
++Get build revision info from: /<<PKGBUILDDIR>>/debian/build/build_tools/autorevision.cache
++NETCODE_VERSION_MAJOR: 0x4000
++NETCODE_VERSION_MINOR: 72
[104/389] Building CXX object lib/netplay/CMakeFiles/netplay.dir/netjoin_stub.cpp.o
[105/389] Building CXX object lib/sdl/CMakeFiles/sdl-backend.dir/cursors_sdl.cpp.o
[106/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/tex.cpp.o
[107/389] Building CXX object lib/netplay/CMakeFiles/netplay.dir/netlog.cpp.o
[108/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/screen.cpp.o
[109/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/textdraw.cpp.o
[110/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/piedraw.cpp.o
[111/389] Building CXX object lib/netplay/CMakeFiles/netplay.dir/netqueue.cpp.o
[112/389] Building CXX object lib/framework/CMakeFiles/framework.dir/wzconfig.cpp.o
[113/389] Linking CXX static library lib/framework/libframework.a
[114/389] Linking CXX static library lib/exceptionhandler/libexception-handler.a
[115/389] Linking CXX static library lib/gamelib/libgamelib.a
[116/389] Building CXX object lib/sdl/CMakeFiles/sdl-backend.dir/gfx_api_null_sdl.cpp.o
[117/389] Building CXX object lib/sdl/CMakeFiles/sdl-backend.dir/gfx_api_vk_sdl.cpp.o
[118/389] Building CXX object lib/netplay/CMakeFiles/netplay.dir/nettypes.cpp.o
[119/389] Building CXX object lib/sdl/CMakeFiles/sdl-backend.dir/gfx_api_gl_sdl.cpp.o
[120/389] Building CXX object lib/netplay/CMakeFiles/netplay.dir/netsocket.cpp.o
[121/389] Building CXX object lib/sequence/CMakeFiles/sequence.dir/timer.cpp.o
[122/389] Building CXX object lib/sdl/CMakeFiles/sdl-backend.dir/gfx_api_sdl.cpp.o
[123/389] Building CXX object lib/sound/CMakeFiles/sound.dir/audio_id.cpp.o
[124/389] Building CXX object lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map.cpp.o
FAILED: lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map.cpp.o 
/usr/bin/c++ -DHAVE_CONFIG_H -I/<<PKGBUILDDIR>>/debian/build -I/<<PKGBUILDDIR>>/. -I/<<PKGBUILDDIR>>/3rdparty -I/<<PKGBUILDDIR>>/3rdparty/date/include -I/<<PKGBUILDDIR>>/lib/wzmaplib/include -I/<<PKGBUILDDIR>>/lib/wzmaplib/../../3rdparty -I/<<PKGBUILDDIR>>/3rdparty/quickjs -isystem /<<PKGBUILDDIR>>/3rdparty/glm -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fstack-protector-strong -fstack-clash-protection -O2 -g -DNDEBUG -fPIC -Wpedantic -Wall -Wextra -fno-common -fno-math-errno -Wcast-align -Wcast-qual -Wctor-dtor-privacy -Winit-self -Woverloaded-virtual -Wstrict-null-sentinel -Wwrite-strings -Wpointer-arith -Wmissing-noreturn -Wnon-virtual-dtor -Wnull-dereference -Wduplicated-cond -Walloc-zero -Walloca-larger-than=1024 -Wrestrict -Wfloat-conversion -Wformat-security -Wstringop-truncation -Wlogical-op -Wuninitialized -Werror -Wno-float-conversion -Wno-sign-compare -Wno-unused-parameter -Wno-format-truncation -std=c++11 -MD -MT lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map.cpp.o -MF lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map.cpp.o.d -o lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map.cpp.o -c /<<PKGBUILDDIR>>/lib/wzmaplib/src/map.cpp
In file included from /<<PKGBUILDDIR>>/lib/wzmaplib/src/map.cpp:25:
In member function ‘bool nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::is_array() const [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>]’,
    inlined from ‘nonstd::optional_lite::optional<std::vector<T> > WzMap::jsonGetListOfType(const nlohmann::json&, const std::string&, size_t, size_t, const JsonParsingContext&, LoggingProtocol*, bool) [with T = int]’ at /<<PKGBUILDDIR>>/lib/wzmaplib/src/map.cpp:491:19:
/<<PKGBUILDDIR>>/3rdparty/json/json.hpp:20235:16: error: potential null pointer dereference [-Werror=null-dereference]
20235 |         return m_type == value_t::array;
      |                ^~~~~~
cc1plus: all warnings being treated as errors
[125/389] Building CXX object lib/sound/CMakeFiles/sound.dir/audio.cpp.o
[126/389] Building CXX object lib/sound/CMakeFiles/sound.dir/oggvorbis.cpp.o
[127/389] Building CXX object lib/sequence/CMakeFiles/sequence.dir/sequence.cpp.o
[128/389] Building CXX object lib/sound/CMakeFiles/sound.dir/cdaudio.cpp.o
[129/389] Building CXX object lib/sdl/CMakeFiles/sdl-backend.dir/main_sdl.cpp.o
[130/389] Building CXX object lib/ivis_opengl/CMakeFiles/ivis-opengl.dir/gfx_api_gl.cpp.o
[131/389] Building CXX object lib/netplay/CMakeFiles/netplay.dir/netplay.cpp.o
[132/389] Building CXX object lib/netplay/CMakeFiles/netplay.dir/netreplay.cpp.o
[133/389] Building C object 3rdparty/quickjs/CMakeFiles/quickjs.dir/quickjs.c.o
ninja: build stopped: subcommand failed.
make[1]: *** [debian/rules:21: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:8: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2