Bug#1034249: pvpgn: Do not exit the postinst script early if not in "configure" state

[Laurent Bigonville]

Package: pvpgn
Version: 1.8.5-3
Severity: important

Hello,

Currently the postinst maintainer script exits early if it is not run in
"configure" mode:

#
# Skip, if we are not in "configure" state
#
if [ "$1" != "configure" ]; then
        echo "I: Skipping configuration"
        exit 0
fi

DIRS="bak/charinfo bak/charsave bnmail chanlogs charinfo
      charsave ladders reports status teams users"

for DIR in $DIRS; do
    mkdir -p /var/lib/pvpgn/$DIR
done

INMHO, this is not good as debhelper snippets might not be properly
executed (ie. the ones from dh_installsystemd or dh_installinit)

The script should be changed to something like:


DIRS="bak/charinfo bak/charsave bnmail chanlogs charinfo
      charsave ladders reports status teams users"

if [ "$1" = "configure" ]; then
for DIR in $DIRS; do
    mkdir -p /var/lib/pvpgn/$DIR
done
fi

Kind regards,
Laurent Bigonville

-- System Information:
Debian Release: 12.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-7-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE:fr
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pvpgn depends on:
ii  libc6                      2.36-9
pn  libcdb1                    <none>
pn  libmariadb3                <none>
pn  libpq5                     <none>
ii  libsqlite3-0               3.40.1-2
ii  sysvinit-utils [lsb-base]  3.06-4
ii  zlib1g                     1:1.2.13.dfsg-1

Versions of packages pvpgn recommends:
pn  tinycdb  <none>
ii  wget     1.21.3-1+b2

Versions of packages pvpgn suggests:
pn  default-mysql-server | virtual-mysql-server  <none>
pn  fortune                                      <none>