Bug#1043684: barrage: Fails to build source after successful build

[Lucas Nussbaum]

Source: barrage
Version: 1.0.5-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package barrage
> dpkg-buildpackage: info: source version 1.0.5-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> Making distclean in src
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> Making distclean in gfx
> make[3]: Entering directory '/<<PKGBUILDDIR>>/src/gfx'
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/src/gfx'
> Making distclean in sounds
> make[3]: Entering directory '/<<PKGBUILDDIR>>/src/sounds'
> test -z "" || rm -f 
> test . = "." || test -z "" || rm -f 
> rm -f Makefile
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/src/sounds'
> make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
> test -z "barrage" || rm -f barrage
> rm -f *.o
> rm -f *.tab.c
> test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test . = "." || test -z "" || rm -f 
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
> rm -f ./.deps/SFont.Po
> rm -f ./.deps/bfield.Po
> rm -f ./.deps/chart.Po
> rm -f ./.deps/data.Po
> rm -f ./.deps/main.Po
> rm -f ./.deps/menu.Po
> rm -f ./.deps/particle.Po
> rm -f ./.deps/shots.Po
> rm -f ./.deps/units.Po
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> test -z "barrage.spec" || rm -f barrage.spec
> rm -f config.h stamp-h1
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> test . = "." || test -z "" || rm -f 
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building barrage using existing ./barrage_1.0.5.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file install-sh, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file aclocal.m4, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file barrage.spec, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file compile, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file configure, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file config.h.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file mkinstalldirs, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file depcomp, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file missing, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/gfx/Makefile.in, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/sounds/Makefile.in, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  barrage-1.0.5/barrage.desktop
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/barrage_1.0.5-1.diff.VGnccc
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/barrage_1.0.5-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.