Bug#1044533: grhino: Fails to build source after successful build

[Lucas Nussbaum]

Source: grhino
Version: 0.16.1-4
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> --------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package grhino
> dpkg-buildpackage: info: source version 0.16.1-4
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --without autoreconf
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> [ ! -e Makefile ] || /usr/bin/make clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> test -z "test.o alphabeta.o board.o boardio.o hash.o gtstream.o iter.o order.o parity.o pattern.o proginfo.o grhino.o binfile.o book.o game.o gameinfo.o gevalwin.o ggamewin.o ghistwin.o gpref.o gutil.o load.o opening.o rand.o randboard.o gtp-rhino.o gtp.o aiai.o gen_book.o gen_opening.o gen_pattern.o gen_table.o dump_pattern.o" || rm -f test.o alphabeta.o board.o boardio.o hash.o gtstream.o iter.o order.o parity.o pattern.o proginfo.o grhino.o binfile.o book.o game.o gameinfo.o gevalwin.o ggamewin.o ghistwin.o gpref.o gutil.o load.o opening.o rand.o randboard.o gtp-rhino.o gtp.o aiai.o gen_book.o gen_opening.o gen_pattern.o gen_table.o dump_pattern.o
> test -z "test grhino gtp-rhino aiai gen_book gen_opening gen_pattern gen_table dump_pattern" || rm -f test grhino gtp-rhino aiai gen_book gen_opening gen_pattern gen_table dump_pattern
> test -z "po" || for d in . po ; do test $d != . && (cd $d; /usr/bin/make clean ); done
> make[3]: Entering directory '/<<PKGBUILDDIR>>/po'
> rm -f *.insert-header
> rm -f remove-potcdate.sed
> rm -f stamp-poT
> rm -f core core.* grhino.po grhino.1po grhino.2po *.new.po
> rm -fr *.o
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/po'
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> for f in po/Makefile po/Makefile.in po/remove-potcdate.sed ; \
> 	do [ ! -e $f.debian-rules-orig ] || ( rm -rf $f && mv -v $f.debian-rules-orig $f ) ; \
> done
> renamed 'po/Makefile.debian-rules-orig' -> 'po/Makefile'
> renamed 'po/Makefile.in.debian-rules-orig' -> 'po/Makefile.in'
> renamed 'po/remove-potcdate.sed.debian-rules-orig' -> 'po/remove-potcdate.sed'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building grhino using existing ./grhino_0.16.1.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  grhino-0.16.1/desktop/grhino.desktop
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/grhino_0.16.1-4.diff.1E8Xdh
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/grhino_0.16.1-4_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.