Bug#1045150: retroarch: Fails to build source after successful build

[Lucas Nussbaum]

Source: retroarch
Version: 1.14.0+dfsg-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package retroarch
> dpkg-buildpackage: info: source version 1.14.0+dfsg-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jonathan McDowell <noodles at earth.li>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> touch config.mk
> dh_auto_clean
> 	make -j8 clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf obj-unix
> rm -f retroarch
> rm -f *.d
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> dh_auto_clean -- -C gfx/video_filters/ clean
> 	make -j8 clean -C gfx/video_filters/ clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>/gfx/video_filters'
> rm -f *.o
> rm -f *.so
> make[2]: 'clean' is up to date.
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/gfx/video_filters'
> dh_auto_clean -- -C libretro-common/audio/dsp_filters/ clean
> 	make -j8 clean -C libretro-common/audio/dsp_filters/ clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>/libretro-common/audio/dsp_filters'
> rm -f *.o
> rm -f *.so
> make[2]: 'clean' is up to date.
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/libretro-common/audio/dsp_filters'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building retroarch using existing ./retroarch_1.14.0+dfsg.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  retroarch-1.14.0+dfsg/gfx/common/wayland/idle-inhibit-unstable-v1.c
>  retroarch-1.14.0+dfsg/gfx/common/wayland/idle-inhibit-unstable-v1.h
>  retroarch-1.14.0+dfsg/gfx/common/wayland/xdg-decoration-unstable-v1.c
>  retroarch-1.14.0+dfsg/gfx/common/wayland/xdg-decoration-unstable-v1.h
>  retroarch-1.14.0+dfsg/gfx/common/wayland/xdg-shell.c
>  retroarch-1.14.0+dfsg/gfx/common/wayland/xdg-shell.h
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/retroarch_1.14.0+dfsg-1.diff.H0xjR4
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/retroarch_1.14.0+dfsg-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.