Bug#1045358: noiz2sa: Fails to build source after successful build

[Lucas Nussbaum]

Source: noiz2sa
Version: 0.51a-13
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ---------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package noiz2sa
> dpkg-buildpackage: info: source version 0.51a-13
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_auto_clean --sourcedirectory=src/bulletml/tinyxml clean
> 	cd src/bulletml/tinyxml && make -j8 clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src/bulletml/tinyxml'
> rm -f core tinyxml.o tinyxmlparser.o xmltest.o tinyxmlerror.o xmltest
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src/bulletml/tinyxml'
> dh_auto_clean --sourcedirectory=src/bulletml clean
> 	cd src/bulletml && make -j8 clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src/bulletml'
> rm -f *.o *.a
> make -C tinyxml clean
> make[3]: Entering directory '/<<PKGBUILDDIR>>/src/bulletml/tinyxml'
> rm -f core tinyxml.o tinyxmlparser.o xmltest.o tinyxmlerror.o xmltest
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/src/bulletml/tinyxml'
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src/bulletml'
> dh_auto_clean --sourcedirectory=src clean
> 	cd src && make -j8 clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
> rm -f noiz2sa *.o
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building noiz2sa using existing ./noiz2sa_0.51a.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: ignoring deletion of file src/bulletml/tinyxml/tinyxml.o, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/bulletml/tinyxml/tinyxmlerror.o, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/bulletml/tinyxml/xmltest, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/bulletml/tinyxml/tinyxmlparser.o, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/bulletml/tinyxml/xmltest.o, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  noiz2sa-0.51a/src/bulletml/calc.cpp
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/noiz2sa_0.51a-13.diff.jvGg1H
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/noiz2sa_0.51a-13_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.