Bug#1045446: libretro-bsnes-mercury: Fails to build source after successful build

[Lucas Nussbaum]

Source: libretro-bsnes-mercury
Version: 094+git20220807-8
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libretro-bsnes-mercury
> dpkg-buildpackage: info: source version 094+git20220807-8
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jonathan McDowell <noodles at earth.li>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> /usr/bin/make clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> /bin/sh: 1: git: not found
> rm -f bsnes_mercury_performance_libretro.so ./processor/arm/arm.o ./processor/gsu/gsu.o ./processor/hg51b/hg51b.o ./processor/lr35902/lr35902.o ./processor/r65816/r65816.o ./processor/spc700/spc700.o ./processor/upd96050/upd96050.o ./gb/interface/interface.o ./gb/system/system.o ./gb/scheduler/scheduler.o ./gb/memory/memory.o ./gb/cartridge/cartridge.o ./gb/cpu/cpu.o ./gb/ppu/ppu.o ./gb/apu/apu.o ./gb/cheat/cheat.o ./gb/video/video.o ./sfc/interface/interface.o ./sfc/base/satellaview/satellaview.o ./sfc/system/system.o ./sfc/controller/controller.o ./sfc/cartridge/cartridge.o ./sfc/cheat/cheat.o ./sfc/memory/memory.o ./sfc/chip/icd2/icd2.o ./sfc/chip/bsx/bsx.o ./sfc/chip/nss/nss.o ./sfc/chip/event/event.o ./sfc/chip/sa1/sa1.o ./sfc/chip/superfx/superfx.o ./sfc/chip/armdsp/armdsp.o ./sfc/chip/hitachidsp/hitachidsp.o 
> ./sfc/chip/necdsp/necdsp.o ./sfc/chip/epsonrtc/epsonrtc.o ./sfc/chip/sharprtc/sharprtc.o ./sfc/chip/spc7110/spc7110.o ./sfc/chip/sdd1/sdd1.o ./sfc/chip/obc1/obc1.o ./sfc/chip/hsu1/hsu1.o ./sfc/chip/msu1/msu1.o ./sfc/slot/satellaview/satellaview.o ./sfc/slot/sufamiturbo/sufamiturbo.o ./sfc/chip/dsp1/dsp1.o ./sfc/chip/dsp2/dsp2.o ./sfc/chip/dsp3/dsp3.o ./sfc/chip/dsp4/dsp4.o ./sfc/chip/cx4/cx4.o ./sfc/chip/st0010/st0010.o ./sfc/chip/sgb-external/sgb-external.o ./target-libretro/libretro.o ./sfc/alt/cpu/cpu.o ./sfc/alt/smp/smp.o ./sfc/alt/dsp/dsp.o ./sfc/alt/ppu-performance/ppu.o ./libco/libco.o
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libretro-bsnes-mercury using existing ./libretro-bsnes-mercury_094+git20220807.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: error: cannot represent change to bsnes_mercury_accuracy_libretro.so: binary file contents changed
> dpkg-source: error: add bsnes_mercury_accuracy_libretro.so in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: warning: executable mode 0755 of 'bsnes_mercury_accuracy_libretro.so' will not be represented in diff
> dpkg-source: error: cannot represent change to bsnes_mercury_balanced_libretro.so: binary file contents changed
> dpkg-source: error: add bsnes_mercury_balanced_libretro.so in debian/source/include-binaries if you want to store the modified binary in the debian tarball
> dpkg-source: warning: executable mode 0755 of 'bsnes_mercury_balanced_libretro.so' will not be represented in diff
> dpkg-source: error: unrepresentable changes to source
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libretro-bsnes-mercury_094+git20220807-8_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.