Bug#1047006: pinball-table-gnu: Fails to build source after successful build

[Lucas Nussbaum]

Source: pinball-table-gnu
Version: 0.0.20230219-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package pinball-table-gnu
> dpkg-buildpackage: info: source version 0.0.20230219-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Sylvain Beucler <beuc at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> Making distclean in data/gnu
> make[2]: Entering directory '/<<PKGBUILDDIR>>/data/gnu'
> test -z "libModuleGnu.la" || rm -f libModuleGnu.la
> rm -rf .libs _libs
> rm -f *.o
> rm -f *.lo
> rm -f *.tab.c
> test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test . = "." || test -z "" || rm -f 
> rm -f ./so_locations
> rm -f ./.deps/ModuleGnu.Plo
> rm -f Makefile
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/data/gnu'
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf .libs _libs
> rm -f *.lo
> test -z "" || rm -f 
> rm -f config.h stamp-h1
> rm -f libtool config.lt
> test . = "." || test -z "" || rm -f 
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
> 	rm -f -- ./INSTALL ./README ./ChangeLog ./libltdl/lt__alloc.c ./libltdl/ltdl.c ./libltdl/lt__dirent.c ./libltdl/libltdl/lt_system.h ./libltdl/libltdl/lt__argz_.h ./libltdl/libltdl/lt_error.h ./libltdl/libltdl/lt__strl.h ./libltdl/libltdl/lt__alloc.h ./libltdl/libltdl/lt_dlloader.h ./libltdl/libltdl/lt__glibc.h ./libltdl/libltdl/slist.h ./libltdl/libltdl/lt__dirent.h ./libltdl/libltdl/lt__private.h ./libltdl/loaders/dyld.c ./libltdl/loaders/loadlibrary.c ./libltdl/loaders/preopen.c ./libltdl/loaders/load_add_on.c ./libltdl/loaders/shl_load.c ./libltdl/loaders/dlopen.c ./libltdl/loaders/dld_link.c ./libltdl/configure.ac ./libltdl/slist.c ./libltdl/m4/ltdl.m4 ./libltdl/m4/ltsugar.m4 ./libltdl/m4/ltargz.m4 ./libltdl/m4/lt\~obsolete.m4 ./libltdl/m4/ltversion.m4 ./libltdl/m4/libtool.m4 ./libltdl/m4/ltoptions.m4 
> ./libltdl/aclocal.m4 ./libltdl/Makefile.in ./libltdl/lt__strl.c ./libltdl/ltdl.h ./libltdl/configure ./libltdl/COPYING.LIB ./libltdl/config-h.in ./libltdl/Makefile.am ./libltdl/lt_dlloader.c ./libltdl/config/config.sub ./libltdl/config/install-sh ./libltdl/config/config.guess ./libltdl/config/compile ./libltdl/config/ltmain.sh ./libltdl/config/depcomp ./libltdl/config/missing ./libltdl/README ./libltdl/lt_error.c ./libltdl/lt__argz.c ./aclocal.m4 ./data/gnu/Makefile.in ./autom4te.cache/requests ./autom4te.cache/traces.2 ./autom4te.cache/output.2 ./autom4te.cache/output.3 ./autom4te.cache/output.1 ./autom4te.cache/traces.1 ./autom4te.cache/traces.3 ./autom4te.cache/output.0 ./autom4te.cache/traces.0 ./NEWS ./Makefile.in ./acinclude.m4 ./configure ./config.h.in
> 	rm -f debian/autoreconf.before debian/autoreconf.after
>    dh_clean
> 	rm -f debian/debhelper-build-stamp
> 	rm -rf debian/.debhelper/
> 	rm -f debian/pinball-table-gnu-data.debhelper.log debian/pinball-table-gnu.debhelper.log
> 	rm -f -- debian/pinball-table-gnu.substvars debian/pinball-table-gnu-data.substvars debian/files
> 	rm -fr -- debian/pinball-table-gnu/ debian/tmp/ debian/pinball-table-gnu-data/
> 	find .  \( \( \
> 		\( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
> 	        \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
> 		 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
> 		 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
> 		 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
> 		\) -exec rm -f {} + \) -o \
> 		\( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \) \)
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building pinball-table-gnu using existing ./pinball-table-gnu_0.0.20230219.orig.tar.gz
> dpkg-source: warning: executable mode 0755 of 'libltdl/config.status' will not be represented in diff
> dpkg-source: warning: executable mode 0755 of 'libltdl/libtool' will not be represented in diff
> dpkg-source: info: local changes detected, the modified files are:
>  pinball-table-gnu-0.0.20230219/libltdl/Makefile
>  pinball-table-gnu-0.0.20230219/libltdl/config.h
>  pinball-table-gnu-0.0.20230219/libltdl/config.log
>  pinball-table-gnu-0.0.20230219/libltdl/config.status
>  pinball-table-gnu-0.0.20230219/libltdl/libtool
>  pinball-table-gnu-0.0.20230219/libltdl/stamp-h1
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/pinball-table-gnu_0.0.20230219-1.diff.1I3pIX
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/pinball-table-gnu_0.0.20230219-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.