Bug#1048366: springlobby: Fails to build source after successful build

[Lucas Nussbaum]

Source: springlobby
Version: 0.274-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package springlobby
> dpkg-buildpackage: info: source version 0.274-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Markus Koschany <apo at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> dh clean --buildsystem=cmake
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_auto_clean
> /usr/bin/make -C debian/manpages clean
> make[2]: Entering directory '/<<PKGBUILDDIR>>/debian/manpages'
> rm -f *.6
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/debian/manpages'
> # Ensure we don't build against the embedded version of jsoncpp
> rm -f -r src/downloader/lib/src/lib/jsoncpp
> rm -f -r src/lsl/lib/jsoncpp
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--buildsystem=cmake
>    dh_clean -O--buildsystem=cmake
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building springlobby using existing ./springlobby_0.274.orig.tar.bz2
> dpkg-source: warning: ignoring deletion of directory src/downloader/lib/src/lib/jsoncpp
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/LICENSE, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/README.md, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/AUTHORS, use --include-removal to override
> dpkg-source: warning: ignoring deletion of directory src/downloader/lib/src/lib/jsoncpp/include
> dpkg-source: warning: ignoring deletion of directory src/downloader/lib/src/lib/jsoncpp/include/json
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/writer.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/json.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/value.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/features.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/autolink.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/config.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/forwards.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/allocator.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/assertions.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/version.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/reader.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/include/json/json_features.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of directory src/downloader/lib/src/lib/jsoncpp/src
> dpkg-source: warning: ignoring deletion of directory src/downloader/lib/src/lib/jsoncpp/src/lib_json
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/src/lib_json/json_value.cpp, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/src/lib_json/json_valueiterator.inl, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/src/lib_json/json_writer.cpp, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/src/lib_json/json_tool.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file src/downloader/lib/src/lib/jsoncpp/src/lib_json/json_reader.cpp, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  springlobby-0.274/cmake/FindJsoncpp.cmake
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/springlobby_0.274-1.diff.dBAwyM
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/springlobby_0.274-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.