Bug#1030678: dhewm3: An additional copyright entry may be appropriate

[James Addison]

Package: dhewm3
Version: 1.5.2+dfsg-1
Severity: normal

Dear Maintainer,

I've recently been looking at some of the dhewm3 upstream source code as part
of packaging another game based on dhewm3 (quadrilateralcowboy), and today I've
been re-reviewing the copyright entries in my package.

There isn't currently a copyright entry for dhewg (the creator and early author
of the dhewm3 fork) in either my package or dhewm3.

Although dhewg made significant contributions and changes to the codebase,
there _are_ some files that they have not modified, and those have a variety of
filename extensions and exist in a variety of directories.

Suggested resolution:

>From comparing commit d57f438db1abb86d5b719abab572420c02f1fc9b (latest upstream
at time of writing) to commit 15597777fc31d6d9fe0d48848e5c97b07e470b79 (last
pre-fork commit), I believe that every 'CMakeLists.txt', '.c', '.cpp', '.h',
'.m4', and '.py' file in the codebase was updated by dhewg - and so it may be
fair to add a second glob file stanza (after the first, existing iD Software
wildcard glob) to attribute files matching those to both iD Software and also
dhewg.

That won't do a perfect job of attributing all of their changes -- something
that could involve lengthy analysis and might result in an excessively detailed
copyright file -- but I think that it would be an improvement and should cover
the vast majority (if not all) of the elements that produce the resulting
dhewm3 binaries distributed in Debian.

I'm planning to apply the suggested resolution to my packaging of and could
open an equivalent merge request for dhewm3's repository on Salsa too, if that
makes sense to you.

Thanks,
James

[1] - https://salsa.debian.org/jayaddison/quadrilateralcowboy/