Bug#1031621: game-data-packager: I broke --install in v72

[Simon McVittie]

Control: severity -1 serious
Control: tags -1 + pending

On Sun, 19 Feb 2023 at 14:13:20 +0100, Alexandre Detiste wrote:
> I broke "--install" flag in v72. It's fixed now in git.
> This would likely needs a new upload before the hard freeze.

Setting this as RC as a reminder that we need to address it before
the freeze.

Sorry, I don't routinely test --install because I prefer to generate
a .deb unprivileged, and install it as a separate transaction. Perhaps
now that autopkgtest has a needs-sudo restriction, we should have an
autopkgtest that downloads *and installs* shareware game data using pkexec
and/or sudo.

> Trying to do more testing and polishing

Thanks! Bug reports are always welcome, with or without a fix.

If you can see how to fix something, fixes for important issues can be
insta-committed, but if an issue is less important, at this point in the
release cycle I'd prefer it as a MR so we can decide whether to land it
before or after Debian 12.

> BTW: pkexec is not reliable over ssh, should sudo be prefered ?

Are you talking about the failure mode where you're logged in to a GUI,
but running pkexec over ssh, the password prompt pops up in the GUI and
you don't see it in your ssh session? Or something different?

I personally think pkexec is a better default because it integrates better
with desktop environments, particularly for inexperienced users without
specialized requirements, and those are the users who are least well-placed
to reconfigure g-d-p to do something different.

In general, if pkexec is unreliable in some way, please report pkexec bugs
with steps to reproduce (those bugs might be resolved wontfix if it's
working as intended, but that's an answer too).

The default to pkexec has been there since 2015 if my reading of `git
log` is correct, so I'd say now is not the time to go changing it unless
there's a bad failure mode that's likely to be common (in which case
please open a bug with steps to reproduce).

> Tags: +pending

FYI the syntax when you're opening a bug is "Tags: pending".

    smcv