Bug#1031654: game-data-packager: the heuristic should prefer another tool than pkexec over an SSH connection

[Alexandre Detiste]

Package: game-data-packager
Version: 72
Severity: minor


The heuristic could user "'SSH_CONNECTION' is in os.environ" and/or sys.stdin.isatty()


---

Without a PTY:

tchet at brix ~/git/game-data-packager $ ssh localhost game-data-packager soltys --install --install-method apt
tchet at localhost's password:
INFO:game_data_packager.build:will not produce "soltys-es-data" because "es" is not in LANGUAGE selection
INFO:game_data_packager.build:will not produce "soltys-pl-data" because "pl" is not in LANGUAGE selection
INFO:game_data_packager.download:downloading http://scummvm.org/frs/extras/Soltys/soltys-en-v1.0.zip
INFO:game_data_packager.packaging.deb:generating package soltys-en-data
Error creating textual authentication agent: Error opening current controlling terminal for the process (`/dev/tty'): No such device or address
generated "/home/tchet/soltys-en-data_1.0+72_all.deb"
using pkexec to obtain root privileges and install the package(s)

(please not that stderr and stdout have been mixed-up,
the "Error creating..." likely happens last)


-----

With a PTY:

tchet at brix ~/git/game-data-packager $ ssh localhost
tchet at localhost's password:
Linux brix 6.1.0-3-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.8-1 (2023-01-29) x86_64
....
Last login: Sun Feb 19 13:33:53 2023 from 192.168.2.12

tchet at brix ~ $ game-data-packager soltys --install --install-method apt
INFO:game_data_packager.build:will not produce "soltys-es-data" because "es" is not in LANGUAGE selection
INFO:game_data_packager.build:will not produce "soltys-pl-data" because "pl" is not in LANGUAGE selection
INFO:game_data_packager.download:downloading http://scummvm.org/frs/extras/Soltys/soltys-en-v1.0.zip
extracting vol.cat from /tmp/gdptmp.0p6shwau/soltys-en-v1.0.zip
extracting vol.dat from /tmp/gdptmp.0p6shwau/soltys-en-v1.0.zip
extracting license.txt from /tmp/gdptmp.0p6shwau/soltys-en-v1.0.zip
INFO:game_data_packager.packaging.deb:generating package soltys-en-data
generated "/home/tchet/soltys-en-data_1.0+72_all.deb"
using pkexec to obtain root privileges and install the package(s)
==== AUTHENTICATING FOR org.freedesktop.policykit.exec ====
Authentication is needed to run `/usr/bin/apt-get' as the super user
Authenticating as: root
Password:
polkit-agent-helper-1: error response to PolicyKit daemon: GDBus.Error:org.freedesktop.PolicyKit1.Error.Failed: No session for cookie
==== AUTHENTICATION FAILED ====
Error executing command as another user: Not authorized

This incident has been reported.



-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (501, 'testing'), (450, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-3-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE:fr
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages game-data-packager depends on:
ii  python3         3.11.1-3
ii  python3-debian  0.1.49
ii  python3-yaml    6.0-3+b2

Versions of packages game-data-packager recommends:
ii  game-data-packager-runtime  72

Versions of packages game-data-packager suggests:
ii  arj                   3.10.22-26
ii  binutils              2.40-2
ii  cabextract            1.9-3
pn  cdparanoia            <none>
ii  dynamite              0.1.1-2+b2
ii  gcc                   4:12.2.0-3
pn  gdebi | gdebi-kde     <none>
ii  gir1.2-gdkpixbuf-2.0  2.42.10+dfsg-1+b1
ii  innoextract           1.9-0.1
ii  lgc-pg                1.4.4-1
pn  lgogdownloader        <none>
ii  lhasa [lzh-archiver]  0.3.1-4+b1
ii  make                  4.3-4.1
ii  p7zip-full            16.02+dfsg-8
ii  pkexec                122-3
ii  python3-gi            3.42.2-3+b1
pn  python3-omg           <none>
ii  python3-pil           9.4.0-1.1+b1
ii  steam                 1:1.0.0.75+ds-5
ii  steamcmd              0~20180105-5
ii  unace-nonfree         2.5-9
ii  unar                  1.10.7+ds1+really1.10.1-2+b1
ii  unrar                 1:6.2.5-1
ii  unshield              1.4.2-1
ii  unzip                 6.0-27
ii  vorbis-tools          1.4.2-1+b1
ii  xdelta                1.1.3-10.4
ii  xdelta3               3.0.11-dfsg-1.2
pn  xorriso               <none>

-- no debconf information