Bug#1039893: steam-installer: Dangling symlink in package: /usr/share/pixmaps/steam_tray_mono.png, breaks tray icon

[Simon McVittie]

On Thu, 29 Jun 2023 at 11:53:53 +0200, Ralf Jung wrote:
> this package ships a symlink /usr/share/pixmaps/steam_tray_mono.png that points to
> ../icons/hicolor/48x48/apps/steam_tray_mono.png. However, that target file does not exist:
...
> As a consequence of this, the systray icon for steam is broken.

Broken in what environment? What component are you using to display tray
icons? It's working OK in GNOME with gnome-shell-extension-appindicator,
but there are several code paths that a tray icon could potentially
go through (KDE status notifier, Ubuntu appindicators, legacy Xembed,
and probably more).

We are no longer able to ship Valve's proprietary steam_tray_mono.png
in /usr, in order to make steam-installer a pure "installer" package
that can be in contrib. When a user runs /usr/games/steam, the actual
proprietary files get downloaded, and a symbolic link to the icon is
created in ~/.local/share/icons/hicolor/48x48/apps/steam_tray_mono.png
(but this happens in an unprivileged process with no access to /usr).

As a first attempt at fixing this, I'm going to remove the dangling
symlink, which will hopefully result in the icon being loaded from
~/.local/share/icons/hicolor/48x48/apps/steam_tray_mono.png. If that
isn't successful, please reopen the bug and provide more details of your
environment: it's possible that for some desktop environments it will need
a symlink in some other location like ~/.icons or ~/.local/share/icons.

Thanks,
    smcv