Bug#1037890: warzone2100: ftbfs with GCC-13

[Matthias Klose]

Package: src:warzone2100
Version: 4.3.3-3
Severity: normal
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-13

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-13/g++-13, but succeeds to build with gcc-12/g++-12. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2023/05/22/logs/warzone2100_4.3.3-3_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 13, either set CC=gcc-13 CXX=g++-13 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-13/porting_to.html

[...]
      |                                                        ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: In function ‘bool PHYSFS_writeULE8(PHYSFS_File*, int)’:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:171:57: error: ‘uint8_t’ was not declared in this scope
  171 |         return (WZ_PHYSFS_writeBytes(file, &val, sizeof(uint8_t)) == sizeof(uint8_t));
      |                                                         ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:32:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   31 | #include <functional>
  +++ |+#include <cstdint>
   32 | 
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: At global scope:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:179:55: error: ‘uint8_t’ has not been declared
  179 | static inline bool PHYSFS_readULE8(PHYSFS_file *file, uint8_t *val)
      |                                                       ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: In function ‘bool PHYSFS_readULE8(PHYSFS_File*, int*)’:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:181:55: error: ‘uint8_t’ was not declared in this scope
  181 |         return (WZ_PHYSFS_readBytes(file, val, sizeof(uint8_t)) == sizeof(uint8_t));
      |                                                       ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:181:55: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: At global scope:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:189:56: error: ‘uint8_t’ has not been declared
  189 | static inline bool PHYSFS_writeUBE8(PHYSFS_file *file, uint8_t val)
      |                                                        ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: In function ‘bool PHYSFS_writeUBE8(PHYSFS_File*, int)’:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:191:57: error: ‘uint8_t’ was not declared in this scope
  191 |         return (WZ_PHYSFS_writeBytes(file, &val, sizeof(uint8_t)) == sizeof(uint8_t));
      |                                                         ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:191:57: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: At global scope:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:199:55: error: ‘uint8_t’ has not been declared
  199 | static inline bool PHYSFS_readUBE8(PHYSFS_file *file, uint8_t *val)
      |                                                       ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: In function ‘bool PHYSFS_readUBE8(PHYSFS_File*, int*)’:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:201:55: error: ‘uint8_t’ was not declared in this scope
  201 |         return (WZ_PHYSFS_readBytes(file, val, sizeof(uint8_t)) == sizeof(uint8_t));
      |                                                       ^~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:201:55: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: In function ‘bool PHYSFS_writeBEFloat(PHYSFS_File*, float)’:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:212:17: error: ‘uint32_t’ does not name a type
  212 |                 uint32_t i;
      |                 ^~~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:212:17: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:215:52: error: ‘union PHYSFS_writeBEFloat(PHYSFS_File*, float)::<unnamed>’ has no member named ‘i’
  215 |         return (PHYSFS_writeUBE32(file, writeValue.i) != 0);
      |                                                    ^
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h: In function ‘bool PHYSFS_readBEFloat(PHYSFS_File*, float*)’:
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:222:9: error: ‘uint32_t’ was not declared in this scope
  222 |         uint32_t *readValue = (uint32_t *)val;
      |         ^~~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:222:9: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:222:19: error: ‘readValue’ was not declared in this scope
  222 |         uint32_t *readValue = (uint32_t *)val;
      |                   ^~~~~~~~~
/<<PKGBUILDDIR>>/lib/framework/physfs_ext.h:222:42: error: expected primary-expression before ‘)’ token
  222 |         uint32_t *readValue = (uint32_t *)val;
      |                                          ^
cc1plus: all warnings being treated as errors
[1180/1519] Building CXX object lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map_script.cpp.o
[1181/1519] Building CXX object lib/framework/CMakeFiles/framework.dir/resource_lexer.cpp.o
[1182/1519] Building CXX object lib/framework/CMakeFiles/framework.dir/i18n.cpp.o
[1183/1519] Building CXX object lib/framework/CMakeFiles/framework.dir/resource_parser.cpp.o
[1184/1519] Building CXX object lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map.cpp.o
[1185/1519] Building CXX object lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map_stats.cpp.o
[1186/1519] Building CXX object lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map_jsonhelpers.cpp.o
[1187/1519] Building CXX object lib/framework/CMakeFiles/framework.dir/debug.cpp.o
[1188/1519] Building CXX object lib/wzmaplib/CMakeFiles/wzmaplib.dir/src/map_package.cpp.o
ninja: build stopped: subcommand failed.
make[1]: *** [debian/rules:26: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:13: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2