Bug#1038066: mygui FTCBFS: confuses build architecture and host architecture in the build directory

[Helmut Grohne]

Source: mygui
Version: 3.4.2+dfsg-1
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

mygui fails to cross build from source, because debian/rules computes a
different build directory from debhelper as they do not agree on whether
to use the build or host architecture. I'm attaching a patch for your
convenience.

Helmut
-------------- next part --------------
diff --minimal -Nru mygui-3.4.2+dfsg/debian/changelog mygui-3.4.2+dfsg/debian/changelog
--- mygui-3.4.2+dfsg/debian/changelog	2023-06-12 15:30:17.000000000 +0200
+++ mygui-3.4.2+dfsg/debian/changelog	2023-06-15 11:07:34.000000000 +0200
@@ -1,3 +1,10 @@
+mygui (3.4.2+dfsg-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Fix build vs host confusion in build directory. (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Thu, 15 Jun 2023 11:07:34 +0200
+
 mygui (3.4.2+dfsg-1) unstable; urgency=medium
 
   * Team upload.
diff --minimal -Nru mygui-3.4.2+dfsg/debian/rules mygui-3.4.2+dfsg/debian/rules
--- mygui-3.4.2+dfsg/debian/rules	2023-06-12 15:30:17.000000000 +0200
+++ mygui-3.4.2+dfsg/debian/rules	2023-06-15 11:07:34.000000000 +0200
@@ -3,6 +3,8 @@
 # resolves bug #984248: mygui: ftbfs with GCC-11
 export DEB_CPPFLAGS_MAINT_APPEND = -DMYGUI_DONT_REPLACE_NULLPTR
 
+BUILD_DIR=obj-$(DEB_HOST_GNU_TYPE)
+
 DEB_UPSTREAM_VERSION=$(shell dpkg-parsechangelog | sed -rne 's,^Version: ([^+]+).*-.*,\1,p')
 #export DH_VERBOSE=1
 %:
@@ -20,22 +22,22 @@
 	 -DMYGUI_BUILD_DOCS=FALSE -DMYGUI_BUILD_PLUGINS=FALSE \
 	 -DMYGUI_BUILD_TOOLS=FALSE -DMYGUI_USE_SYSTEM_GLEW=TRUE
 	dh_auto_build
-	${MAKE} install -C obj-$(DEB_BUILD_GNU_TYPE) DESTDIR=$(CURDIR)/debian/tmp2
+	${MAKE} install -C $(BUILD_DIR) DESTDIR=$(CURDIR)/debian/tmp2
 #	build for OpenGL3
 	dh_auto_configure -- -DMYGUI_BUILD_DEMOS=FALSE -DMYGUI_RENDERSYSTEM=7 \
 	 -DMYGUI_BUILD_DOCS=FALSE -DMYGUI_BUILD_PLUGINS=FALSE \
 	 -DMYGUI_BUILD_TOOLS=FALSE -DMYGUI_USE_SYSTEM_GLEW=TRUE
 	dh_auto_build
-	${MAKE} install -C obj-$(DEB_BUILD_GNU_TYPE) DESTDIR=$(CURDIR)/debian/tmp2
+	${MAKE} install -C $(BUILD_DIR) DESTDIR=$(CURDIR)/debian/tmp2
 #	Build for Ogre platform, and tools
 	dh_auto_configure -- -DMYGUI_BUILD_DEMOS=FALSE -DMYGUI_RENDERSYSTEM=3 \
 	 -DMYGUI_BUILD_DOCS=TRUE -DMYGUI_BUILD_PLUGINS=FALSE \
 	 -DMYGUI_BUILD_TOOLS=FALSE
 	dh_auto_build
-	${MAKE} install -C obj-$(DEB_BUILD_GNU_TYPE) DESTDIR=$(CURDIR)/debian/tmp2
+	${MAKE} install -C $(BUILD_DIR) DESTDIR=$(CURDIR)/debian/tmp2
 
 override_dh_install:
-	cd obj-$(DEB_BUILD_GNU_TYPE)/Docs && doxygen Doxyfile && cd $(CURDIR)
+	cd $(BUILD_DIR)/Docs && doxygen Doxyfile && cd $(CURDIR)
 	find debian/ -type d -empty -delete
 	mkdir -p $(CURDIR)/debian/tmp/usr/lib/${DEB_HOST_MULTIARCH}/pkgconfig
 	mv $(CURDIR)/debian/tmp/usr/lib/pkgconfig/MYGUI.pc $(CURDIR)/debian/tmp/usr/lib/${DEB_HOST_MULTIARCH}/pkgconfig/MYGUI.pc
@@ -45,7 +47,7 @@
 	dh_installdocs -X.md5 -X.map -Xjquery.js
 
 debian/%.docs: debian/%.docs.in
-	sed 's/@BUILD_DIR@/obj-$(DEB_BUILD_GNU_TYPE)/g' $< > $@
+	sed 's/@BUILD_DIR@/$(BUILD_DIR)/g' $< > $@
 
 override_dh_makeshlibs:
 	dh_makeshlibs -- -c0 -v$(DEB_UPSTREAM_VERSION)