Bug#1064139: ogre-1.12: FTBFS: error: ‘BuildFontAtlas’ is not a member of ‘ImGuiFreeType’

[Aurelien Jarno]

Source: ogre-1.12
Version: 1.12.10+dfsg2-3
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Dear maintainer,

ogre-1.12 fails to build from source, probably due to a change in imgui.
From my build log on amd64:

| [ 73%] Building CXX object Components/Overlay/CMakeFiles/OgreOverlay.dir/src/OgreFontManager.cpp.o
| cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/Components/Overlay && /usr/bin/c++ -DOgreOverlay_EXPORTS -I/<<PKGBUILDDIR>>/Components/Overlay/include -I/usr/include/freetype2 -I/misc/freetype -I/<<PKGBUILDDIR>>/OgreMain/include -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/include -isystem /usr/include/imgui -isystem /usr/include/stb -Wall -Winit-self -Wcast-qual -Wwrite-strings -Wextra -Wundef -Wmissing-declarations -Wno-unused-parameter -Wshadow -Wno-missing-field-initializers -Wno-long-long -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -pipe -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -msse -std=c++11 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT Components/Overlay/CMakeFiles/OgreOverlay.dir/src/OgreFontManager.cpp.o -MF CMakeFiles/OgreOverlay.dir/src/OgreFontManager.cpp.o.d -o CMakeFiles/OgreOverlay.dir/src/OgreFontManager.cpp.o -c /<<PKGBUILDDIR>>/Components/Overlay/src/OgreFontManager.cpp
| [ 73%] Building CXX object Components/Overlay/CMakeFiles/OgreOverlay.dir/src/OgreImGuiOverlay.cpp.o
| cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/Components/Overlay && /usr/bin/c++ -DOgreOverlay_EXPORTS -I/<<PKGBUILDDIR>>/Components/Overlay/include -I/usr/include/freetype2 -I/misc/freetype -I/<<PKGBUILDDIR>>/OgreMain/include -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/include -isystem /usr/include/imgui -isystem /usr/include/stb -Wall -Winit-self -Wcast-qual -Wwrite-strings -Wextra -Wundef -Wmissing-declarations -Wno-unused-parameter -Wshadow -Wno-missing-field-initializers -Wno-long-long -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -pipe -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -msse -std=c++11 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT Components/Overlay/CMakeFiles/OgreOverlay.dir/src/OgreImGuiOverlay.cpp.o -MF CMakeFiles/OgreOverlay.dir/src/OgreImGuiOverlay.cpp.o.d -o CMakeFiles/OgreOverlay.dir/src/OgreImGuiOverlay.cpp.o -c /<<PKGBUILDDIR>>/Components/Overlay/src/OgreImGuiOverlay.cpp
| /<<PKGBUILDDIR>>/Components/Overlay/src/OgreImGuiOverlay.cpp: In member function ‘void Ogre::ImGuiOverlay::ImGUIRenderable::createFontTexture()’:
| /<<PKGBUILDDIR>>/Components/Overlay/src/OgreImGuiOverlay.cpp:118:20: error: ‘BuildFontAtlas’ is not a member of ‘ImGuiFreeType’
|   118 |     ImGuiFreeType::BuildFontAtlas(io.Fonts, 0);
|       |                    ^~~~~~~~~~~~~~
| make[4]: *** [Components/Overlay/CMakeFiles/OgreOverlay.dir/build.make:121: Components/Overlay/CMakeFiles/OgreOverlay.dir/src/OgreImGuiOverlay.cpp.o] Error 1
| make[4]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| make[3]: *** [CMakeFiles/Makefile2:1187: Components/Overlay/CMakeFiles/OgreOverlay.dir/all] Error 2
| make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| make[2]: *** [Makefile:159: all] Error 2
| make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
| dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j1 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
| make[1]: *** [debian/rules:65: override_dh_auto_build-indep] Error 25
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| make: *** [debian/rules:41: binary] Error 2
| dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

A full build log is also available on riscv64:
https://buildd.debian.org/status/fetch.php?pkg=ogre-1.12&arch=riscv64&ver=1.12.10%2Bdfsg2-3%2Bb1&stamp=1707901622&raw=0

The issue is also visible on the reproducible builds:
https://tests.reproducible-builds.org/debian/rbuild/unstable/amd64/ogre-1.12_1.12.10+dfsg2-3.rbuild.log.gz
https://tests.reproducible-builds.org/debian/rbuild/unstable/arm64/ogre-1.12_1.12.10+dfsg2-3.rbuild.log.gz

Regards
Aurelien